Fixes around logging #24743
Merged
Fixes around logging #24743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Jan 14, 2024
dmatej
commented
- The stop-domain did not print that the domain is not running, but just some method name instead.
- When rolling the server.log file, several messages was lost. Closes GlassFishlogHandler can drop several LogRecord instances when it rotates the server.log file #24737
- Reduced using method handles as parameters, better separation of features.
- Some editors (Vim) delete before save, sometimes GF noticed the logging.properties vanished and then GF stopped its monitoring and reloading. As the file is critical, on this event now GF creates a special thread which resets everything to correct state after the file reappears.
- Rolling the server.log file did not work on Windows when used with --verbose or --watch (also used by Windows Services), because Launcher had it's own handle to the file and Windows blocked attempts to move the file. Now Launcher removed its handler right before it starts the server which configures its own logging and continues writing to the server.log. This relates to Launcher should not touch server.log #24065 .
- This should fill the inability to rotate the log file on windows when it is started with watchdog or verbose. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- When rolling, several log records were lost - doesn't happen any more - Refactoring: separated features to own classes, which resolved some locking and reduced need of sharing method handles. Signed-off-by: David Matějček <[email protected]>
- Some editors save the file so they delete and create it. But when GF noticed that the file was deleted, it disabled the mechanism used to refresh the configuration. - Now it prints the warning, but then creates a special thread waiting until the file is backa again, then configuring the mechanism again. Signed-off-by: David Matějček <[email protected]>
|
|
avpinchuk
approved these changes
Jan 14, 2024
arjantijms
approved these changes
Jan 15, 2024
|
It seems to be working in test environment, but we still didn't deploy it to the production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.