fix cmtTimeoutInSeconds config, it can't take effect when set value 0 in admin UI. #24702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zistrong, please accept ECA |
avpinchuk
approved these changes
Dec 10, 2023
dmatej
approved these changes
Dec 10, 2023
|
This change not only changes the default behavior of GlassFish, but also causes the following issue to recur when the Transaction Timeout is set to 0. I'll try to come up with another fix this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in adminUI server-config--->Transaction Service page, if I set Transaction Timeout to value 0, accoring to the description, we should disable timeout setting. but now, it is set to 120s in hard code. I fix the bug.
after this refactor, the default values is 120s, if we set 0, timeout setting will be disabled.