Add removed constructor to restore backward compatibility #22589
Conversation
| * @param password the clear text password for the connection | ||
| */ | ||
| public AuthenticationInfo(String user, String password) { | ||
| this(user, password.toCharArray()); |
There was a problem hiding this comment.
👎 I've seen many recommendations to avoid using String for password passing, none in favour of it.
There was a problem hiding this comment.
this is adding in a previously removed constructor which IntelliJ uses changing to char[] would again break IntelliJ. So the question is should we fix IntelliJ support or should IntelliJ fix the plugin?
There was a problem hiding this comment.
From IntelliJ IDEA 2018.2.4 build 18 Sept. 2018, did NOT encounter the problem anymore.
There was a problem hiding this comment.
Problem is still reproducing with any version of IntelliJ IDEA. But backward compatibility was restored in Payara (payara/Payara#2328).
There was a problem hiding this comment.
Problem is still reproducing with any version of IntelliJ IDEA.
Yet Marc' comment for IDEA-194181 remains uncorrected.
But backward compatibility was restored in Payara (payara/Payara#2328).
IMO - it's bad idea to have this Ctor back just for testability. Should be fixed in Intelli-J or other clients.
It is class in com.sun package, and some, first example from @BalusC recommend:
It's preferable to not use those classes directly in your code as it would make your code tight coupled to the implementation.
Thus - developers shall follow changes in API used.
Add removed constructor to
com.sun.enterprise.admin.util.AuthenticationInfoto restore backward compatibility. This fixes https://youtrack.jetbrains.com/issue/IDEA-194181 .