Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] DatabasePlatform.wasFailureCommunicationBased() fix #2006

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

rfelcman
Copy link
Contributor

Fixes #1970 .
This bug should happens is no pingSQL DB platform property is specified and query execution fails.

@lukasj lukasj merged commit 3b5da43 into eclipse-ee4j:master Nov 27, 2023
4 checks passed
@rfelcman rfelcman deleted the conn_failure_check branch November 28, 2023 12:34
@TomerHeber
Copy link

Hi,

Is there a reason this fix isn't backported to 3.x and 4.x ? (and just to 2.x).

Thanks!

@rfelcman
Copy link
Contributor Author

rfelcman commented Aug 8, 2024

Hi,

Is there a reason this fix isn't backported to 3.x and 4.x ? (and just to 2.x).

Thanks!

In progress now see #2228 #2229 .
Backport to 2.7 is done #2009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatabasePlatform.wasFailureCommunicationBased() seems broken when no pingSQL is defined.
3 participants