Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven build issue with Maven 3.8.2 fix #1244

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Maven build issue with Maven 3.8.2 fix #1244

merged 5 commits into from
Sep 3, 2021

Conversation

rfelcman
Copy link
Contributor

@rfelcman rfelcman commented Aug 16, 2021 •
edited
Loading

Fixes #1242

@pzygielo

This comment has been minimized.

Sign in to view
@michael-o
Copy link

There is now a similar case: http://mail-archives.apache.org/mod_mbox/maven-dev/202108.mbox/%3CCAGjJkv0CL63THRrT4w7Fpj%2BNQ5NyjtnAOJ8yW7OAmbMkxGjT4Q%40mail.gmail.com%3E. I'd like to wait for @mickaelistria's response.

@mickaelistria
Copy link

I think the proper way to check whether a project is in the reactor or not is session.getProjects().contains(project). But maybe I'm missing a part of the Maven API contract. At least, there is no test in Maven that assumed that project.getBasedir() == null for a project that's not in the reactor...

lukasj
lukasj reviewed Aug 23, 2021
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@rfelcman rfelcman force-pushed the maven_build_directory-maven-plugin_removal branch from e3fdbc1 to 22d62b8 Compare September 1, 2021 07:04
@rfelcman rfelcman force-pushed the maven_build_directory-maven-plugin_removal branch from 22d62b8 to 36cd123 Compare September 2, 2021 19:47
lukasj
lukasj reviewed Sep 3, 2021
View reviewed changes
bundles/eclipselink/pom.xml Outdated Show resolved Hide resolved
lukasj
lukasj approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a fix for issue you see available, will push that through the next PR in a minute or two...

@lukasj lukasj merged commit f514879 into eclipse-ee4j:master Sep 3, 2021
@lukasj lukasj mentioned this pull request Sep 3, 2021
Merged
@rfelcman rfelcman deleted the maven_build_directory-maven-plugin_removal branch September 4, 2021 08:54
@lukasj lukasj mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfscholte rfscholte rfscholte left review comments

@michael-o michael-o michael-o left review comments

@lukasj lukasj lukasj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with building with maven 3.8.2
6 participants
@rfelcman @pzygielo @michael-o @mickaelistria @rfscholte @lukasj