Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MailHandler LogManager support for mail entries #119

Closed
jmehrens opened this issue Jan 18, 2024 · 1 comment · Fixed by #122
Closed

MailHandler LogManager support for mail entries #119

jmehrens opened this issue Jan 18, 2024 · 1 comment · Fixed by #122
Assignees
@jmehrens
Labels
enhancement New feature or request

Comments

@jmehrens
Copy link
Contributor

jmehrens commented Jan 18, 2024 •
edited
Loading

During development of #110 I didn't include log manager support for reading mail entries. The MailHandler has always read mail entries as top level entries. After thinking more about this the MailHandler should allow configuration of mail entries via a local property as there as been a long standing issue where properties are cleared before invoking close. See: https://bugs.openjdk.org/browse/JDK-7092981

The way the MailHandler worked around this issue is to lazy store the values as they are read and by triggering those reads through verification. By adding the a mailEntries property this will allow the MailHandler to work with verification off. It also provides a unique namespace for this handler to override top level mail settings.
@jmehrens jmehrens self-assigned this Jan 18, 2024
@jmehrens jmehrens changed the title MailHandler logmanger support for mail entries MailHandler LogManger support for mail entries Jan 18, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 20, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
05ed87f 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 20, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
f872917 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 20, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
97de6b2 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 20, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
b3d36fa 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 20, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
77f699b 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
044218e 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
be7dcaa 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
3537747 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
b33db4b 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
73db9ba 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
3263ce6 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
984d2b0 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 22, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
6028528 
Signed-off-by: jmehrens <[email protected]>
@jmehrens jmehrens mentioned this issue Jan 22, 2024
Merged
@jmehrens jmehrens added the enhancement New feature or request label Jan 22, 2024
jmehrens added a commit to jmehrens/angus-mail that referenced this issue Jan 23, 2024
@jmehrens
MailHandler LogManger support for mail entries eclipse-ee4j#119
2d15019 
Signed-off-by: jmehrens <[email protected]>
jmehrens added a commit that referenced this issue Jan 23, 2024
@jmehrens
MailHandler LogManger support for mail entries #119 (#122)
4b7360d 
MailHandler LogManger support for mail entries #119
Signed-off-by: jmehrens <[email protected]>
@jmehrens
Copy link
Contributor Author

Committed to 2.0.3 as:
4b7360d

@jmehrens jmehrens changed the title MailHandler LogManger support for mail entries MailHandler LogManager support for mail entries Feb 17, 2024
@lukasj lukasj linked a pull request Mar 3, 2024 that will close this issue
MailHandler LogManager support for mail entries #119 #122
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmehrens jmehrens

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MailHandler LogManager support for mail entries #119 jmehrens/angus-mail
1 participant
@jmehrens