Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removes StatusChecker #96

Merged
merged 2 commits into from
Sep 28, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extensions/common/aws/aws-s3-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@
## Local testing using MinIO

To run AWS integration tests you will need a MinIO instances running:

```
docker run --name miniosource -p 9000:9000 -p 9001:9001 -d -e MINIO_ROOT_USER=root -e MINIO_ROOT_PASSWORD=password bitnami/minio:latest
docker run --name miniodest -p 9002:9000 -p 9003:9001 -d -e MINIO_ROOT_USER=root -e MINIO_ROOT_PASSWORD=password bitnami/minio:latest
```

Then set the two environment variables:

```
S3_ACCESS_KEY_ID=root
S3_SECRET_ACCESS_KEY=password
Expand All @@ -23,7 +25,7 @@ for running integration tests against AWS S3 by environment variable:
$ IT_AWS_ENDPOINT=https://s3.us-east-1.amazonaws.com/ \
IT_AWS_REGION=us-east-1 \
IT_AWS_PROFILE=myprofie \
./gradlew clean test -DincludeTags="AwsS3IntegrationTest" --tests '*S3StatusCheckerIntegrationTest'
./gradlew clean test -DincludeTags="AwsS3IntegrationTest"
```

`IT_AWS_REGION` must be set to your region code in order to avoid
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@
import dev.failsafe.RetryPolicy;
import org.eclipse.edc.aws.s3.AwsClientProvider;
import org.eclipse.edc.aws.s3.AwsTemporarySecretToken;
import org.eclipse.edc.aws.s3.S3BucketSchema;
import org.eclipse.edc.connector.transfer.spi.provision.ProvisionManager;
import org.eclipse.edc.connector.transfer.spi.provision.Provisioner;
import org.eclipse.edc.connector.transfer.spi.provision.ResourceManifestGenerator;
import org.eclipse.edc.connector.transfer.spi.status.StatusCheckerRegistry;
import org.eclipse.edc.runtime.metamodel.annotation.Extension;
import org.eclipse.edc.runtime.metamodel.annotation.Inject;
import org.eclipse.edc.runtime.metamodel.annotation.Setting;
Expand Down Expand Up @@ -75,9 +73,6 @@ public void initialize(ServiceExtensionContext context) {
var manifestGenerator = context.getService(ResourceManifestGenerator.class);
manifestGenerator.registerGenerator(new S3ConsumerResourceDefinitionGenerator());

var statusCheckerReg = context.getService(StatusCheckerRegistry.class);
statusCheckerReg.register(S3BucketSchema.TYPE, new S3StatusChecker(clientProvider, retryPolicy));

registerTypes(typeManager);
}

Expand Down

This file was deleted.

This file was deleted.

Loading