fix(dataplane): deserialize secret depending on content #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
ronjaquensel
changed the title
ronjaquensel
force-pushed
the
fix/457-secret-parsing
branch
from
49319df to
60d22aa
Compare
ndr-brt
reviewed
Oct 30, 2024
...plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSinkFactory.java
Outdated
Show resolved
Hide resolved
...ane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSourceFactory.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Deserializes the secret obtained from the vault to either an
AwsSecretTokenor anAwsTemporarySecretTokendepending on whether it contains asessionTokenfield or not.Why it does that
To allow both the usage of static and temporary credentials with the S3 data plane. Previously, the secret was always deserialized directly to an
AwsTemporarySecretToken, which caused the transfer to fail if static credentials were used.Further notes
The code for deserializing the secret has been duplicated for
S3DataSourceFactoryandS3DataSinkFactoryfor now, as also the code for creating the S3 client request is duplicated. Refactoring to remove these duplications should be done in another PR.Linked Issue(s)
Closes #457