Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compile issue #102

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 6, 2023

What this PR changes/adds

Fix compile issue on S3DataSource

Why it does that

not compiling

@wolf4ood wolf4ood self-assigned this Oct 6, 2023
@wolf4ood wolf4ood added the bug Something isn't working label Oct 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c0890dc) 78.53% compared to head (6b86ef8) 78.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   78.53%   78.36%   -0.18%     
==========================================
  Files          19       19              
  Lines         452      453       +1     
  Branches       13       13              
==========================================
  Hits          355      355              
- Misses         96       97       +1     
  Partials        1        1              
Files Coverage Δ
...e/edc/connector/dataplane/aws/s3/S3DataSource.java 47.82% <0.00%> (-2.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit f5c269a into eclipse-edc:main Oct 6, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants