Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

fix: add Monitor to EdcHttpClient's arguments #66

Merged
merged 1 commit into from
Dec 23, 2022
Merged

fix: add Monitor to EdcHttpClient's arguments #66

merged 1 commit into from
Dec 23, 2022

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds the Monitor argument to the EdcHttpClient's constructor args when creating the RegistrationService CLI

Why it does that

compile errors

Further notes

.

Linked Issue(s)

.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Dec 23, 2022
@paullatzelsperger paullatzelsperger merged commit 59f3c3d into eclipse-edc:main Dec 23, 2022
@paullatzelsperger paullatzelsperger deleted the bug/fix_edchttpclient_args branch December 23, 2022 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ronjaquensel ronjaquensel ronjaquensel approved these changes

@ndr-brt ndr-brt Awaiting requested review from ndr-brt

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullatzelsperger @ronjaquensel