Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

refactor: Clean up SPI #44

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

bscholtes1A
Copy link
Contributor

@bscholtes1A bscholtes1A commented Oct 14, 2022

What this PR changes/adds

Move *-spi directory out of extensions.
Also relocate some stuff of resources into system-tests as it is done in https://github.com/eclipse-dataspaceconnector/IdentityHub/tree/main/system-tests.

Why it does that

Clean up.

Further notes

Linked Issue(s)

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 16.82% // Head: 16.82% // No change to project coverage 👍

Coverage data is based on head (0756242) compared to base (709b950).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #44   +/-   ##
=========================================
  Coverage     16.82%   16.82%           
  Complexity       37       37           
=========================================
  Files            32       32           
  Lines           523      523           
  Branches         26       26           
=========================================
  Hits             88       88           
  Misses          435      435           
Impacted Files Coverage Δ
...ctor/registration/DataspaceRegistrationPolicy.java 0.00% <ø> (ø)
...ctor/registration/authority/model/Participant.java 0.00% <ø> (ø)
...egistration/authority/model/ParticipantStatus.java 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bscholtes1A bscholtes1A force-pushed the refactor/clean-up-spi branch from fd81b5d to 1aab862 Compare October 14, 2022 15:30
@bscholtes1A bscholtes1A force-pushed the refactor/clean-up-spi branch from 1aab862 to 0756242 Compare October 14, 2022 15:34
@bscholtes1A bscholtes1A merged commit 4b33dc5 into eclipse-edc:main Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants