feat: add excludeTags flag #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
feat/add_excludeTags_flag
branch
from
9962cc4 to
c79d9d1
Compare
ndr-brt
reviewed
Mar 29, 2024
| if (includedTags.length > 0) { | ||
| testTask.useJUnitPlatform(platform -> platform.includeTags(includedTags)); | ||
| //... and possibly black-list excluded tags | ||
| if (excludedTags.length > 0) { |
There was a problem hiding this comment.
what is the case where someone wants to include and exclude tags in the same execution?
I see two cases:
- default (no tags included) -> possibility to include
- runAllTests (all tags included) -> possibility to exclude
There was a problem hiding this comment.
this could happen on "derived" tags, e.g. someone includes ComponentTest but wants to exclude AVerySpecialComponentTest
wolf4ood
approved these changes
Mar 29, 2024
ndr-brt
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a flag
excludeTagsto exclude certain test tags, analogous to theincludeTagsflag. That waywe can execute
./gradlew test -DrunAllTests -DexcludeTags="foo,bar", effectively blacklisting certain tags.Why it does that
Sometimes its easier to blacklist certain tags, than whitelist all the others.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.