Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid unnecessary meta model dependency injection #198

Closed
wants to merge 1 commit into from

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Dec 4, 2023

What this PR changes/adds

Avoids to inject runtime-metamodel automatically on every extension that applies the build plugin

Why it does that

it is not really necessary, and it will remove some complexity (the runtime-metamodel version is always equal to the edc version)

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #197

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link

github-actions bot commented Dec 4, 2023

Test Results

40 tests  ±0   40 ✔️ ±0   16s ⏱️ ±0s
10 suites ±0     0 💤 ±0 
10 files   ±0     0 ±0 

Results for commit 20f1c03. ± Comparison against base commit 28c2dbb.

Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, is there much difference between the runtime-metamodel and others, such as Jackson?

I'm assuming, that doing this (=removing default dep), and having it exposed through an api(...) in the SPI modules of EDC, we'd mostly achieve the end result, but then the same argument could be made for getting rid of all default dependencies.

If we do - and I'm not saying we shouldn't - then I think this needs to be discussed in the Technical Committers group and captured in a D-R.

@ndr-brt
Copy link
Member Author

ndr-brt commented Dec 11, 2023

superseded by #200

@ndr-brt ndr-brt closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid metamodel automatic dependency
2 participants