Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken protocol version api specification #4681

Merged

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

fix broken ProtocolVersionApi documentation that generates the swagger spec.

Why it does that

Api documentation is incorrect, causing an invalid swagger spec to be generated.

swagger_error

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@bscholtes1A bscholtes1A added bug Something isn't working documentation Improvements or additions to documentation labels Dec 18, 2024
@bscholtes1A bscholtes1A requested a review from wolf4ood December 18, 2024 18:09
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the management-api-version.json

@bscholtes1A bscholtes1A force-pushed the fix/protocol_version_api_spec branch from 25b1d60 to ec616b8 Compare December 19, 2024 08:51
@bscholtes1A
Copy link
Contributor Author

you need to update the management-api-version.json

date updated

@bscholtes1A bscholtes1A force-pushed the fix/protocol_version_api_spec branch from ec616b8 to 91b24c6 Compare December 19, 2024 09:33
@bscholtes1A bscholtes1A requested a review from ndr-brt December 19, 2024 09:44
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bscholtes1A bscholtes1A merged commit c530bcf into eclipse-edc:main Dec 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants