Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatibility tests for DSP #4667

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Dec 6, 2024

What this PR changes/adds

This PR adds a compatibility test for DSP.

The Technology compatibility Kit (TCK) is spun up in a Docker container and executed against a connector instance.

Note that two things are necessary to achieve that:

  1. a test fixture: a connector that contains an special extension to seed test data and expose a trigger endpoint. This is located at system-tests/dsp-compatibility-tests/connector-under-test. The fixture will come in a subsequent PR!
  2. a test harness: a TCK instance running in Docker. This is achieved using Testcontainers, and a configuration file located at system-tests/dsp-compatibility-tests/compatibility-test-runner/src/test/resources/docker.tck.properties

Why it does that

to guarantee compatibility with DSP

Further notes

  • the test is currently disabled, because there appear to be bugs in the DSP impl. of EDC
  • the test should not be executed during normal CI runs due to the impact it has on test runtime. With this PR, it is run in a nightly build job.
  • we might consider publishing the test fixture as Maven artifact in the future. That'll be a separate work item though.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Dec 6, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review December 6, 2024 10:05
@paullatzelsperger paullatzelsperger force-pushed the tck_extension branch 5 times, most recently from 601b684 to 41f5df1 Compare December 6, 2024 10:18
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff!

@paullatzelsperger paullatzelsperger merged commit 81feb70 into eclipse-edc:main Dec 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants