Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assignee and assigner serialization as @id #4641

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Nov 21, 2024

What this PR changes/adds

Overrides the JsonObjectFromPolicyTransformer with the assignee and assigner fixes in

  • dsp protocol only version 2024/1
  • management api only version v4alpha

For managing transformers overrides for specific version on management api the DR #4634 has been implemented in this PR

Why it does that

bug fix

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4576

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood added the bug Something isn't working label Nov 21, 2024
@wolf4ood wolf4ood force-pushed the fix/4576_policy_ser branch 4 times, most recently from fdb2100 to 29bf34a Compare November 21, 2024 14:26
@wolf4ood wolf4ood marked this pull request as ready for review November 21, 2024 15:06
@wolf4ood wolf4ood requested a review from jimmarino November 21, 2024 15:06
@wolf4ood wolf4ood force-pushed the fix/4576_policy_ser branch 4 times, most recently from cf82267 to 6871d93 Compare November 25, 2024 08:59
@wolf4ood wolf4ood requested a review from ndr-brt November 26, 2024 08:24
@wolf4ood wolf4ood force-pushed the fix/4576_policy_ser branch from 6871d93 to af23d4c Compare November 26, 2024 10:36
@wolf4ood wolf4ood merged commit 8c49531 into eclipse-edc:main Nov 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assignee and assigner should be an @id on serialization
3 participants