Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken sample runtime link #4589

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

fravl
Copy link
Contributor

@fravl fravl commented Oct 29, 2024

What this PR changes/adds

Fixes the broken link to the sample runtime.
Changes the link from referring from the custom to the basic sample runtime example.

Why it does that

The current link refers to a directory, which no longer exists.

The updated link refers to the basic instead of the custom sample runtime, as this provides an easier entrypoint into connector runtimes.
A link to the custom sample runtime is included in the README.md of the basic sample runtime.

Further notes

Linked Issue(s)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@fravl fravl marked this pull request as draft October 29, 2024 11:26
@wolf4ood
Copy link
Contributor

@fravl

thanks for this PR, please make sure to sign the ECA

@wolf4ood wolf4ood added the bug Something isn't working label Oct 29, 2024
@fravl fravl changed the title fix: update broken sample runtime link docs: update broken sample runtime link Oct 29, 2024
@fravl fravl marked this pull request as ready for review October 29, 2024 11:44
@wolf4ood wolf4ood merged commit 31ad561 into eclipse-edc:main Oct 29, 2024
4 checks passed
@wolf4ood
Copy link
Contributor

Thanks @fravl

@fravl fravl deleted the patch-1 branch October 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants