refactor: optimize dependency graph performances #4587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Does some little tweaks to
DependencyGraph
to improve performance, both time and memory wise.The code used to measure the improvements has been put on
ExtensionLoader
in theloadServiceExtensions
method:With the changes put in place (details in the "further notes" section) I observed, measuring 10 times and extracting the mean value:
these improvements don't look really game changing, but they will be definitely helpful in multiple-connectors environment, plus it's always good to apply good code practices (see below)
Why it does that
startup performances
Further notes
The improvements evolve around:
extensions
: removed 2 unnecessary iterationsReflectiveObjectFactory
intojunit
module as it's only used in test context.Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.