Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract dsp catalog transform lib #4551

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Oct 15, 2024

What this PR changes/adds

Introduces dsp-*-transoform-lib one for each dsp module.

Each transformer can work on a provided schema, which by default for backward compatibility is DSPACE_SCHEMA (v0.8)

Relevant constants for this PR were refactor with the convention:

  • *_TERM : plain properties/types without namespace
  • *_IRI : properties/types with namespace (schema + *_TERM)

An abstract class AbstractNamespaceAwareJsonLdTransformer for handling reusability of transfomers across multiple versions.

Why it does that

multiprotocol support

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4509

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood force-pushed the refactor/4509_dsp_transform_libs branch from 516ac2c to 375b167 Compare October 15, 2024 13:26
@wolf4ood wolf4ood added refactoring Cleaning up code and dependencies dataspace-protocol related to the dataspace protocol labels Oct 15, 2024
@wolf4ood wolf4ood self-assigned this Oct 15, 2024
@wolf4ood wolf4ood force-pushed the refactor/4509_dsp_transform_libs branch from 856ad8e to 5a0f430 Compare October 15, 2024 16:01
@wolf4ood wolf4ood force-pushed the refactor/4509_dsp_transform_libs branch 5 times, most recently from b23ef88 to c537cf2 Compare October 16, 2024 09:16
@wolf4ood wolf4ood force-pushed the refactor/4509_dsp_transform_libs branch from c537cf2 to 5cad8dd Compare October 16, 2024 09:46
@wolf4ood wolf4ood marked this pull request as ready for review October 16, 2024 10:23
@wolf4ood wolf4ood merged commit c79e11c into eclipse-edc:main Oct 17, 2024
27 checks passed
@wolf4ood wolf4ood deleted the refactor/4509_dsp_transform_libs branch October 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor dsp transform modules
2 participants