refactor(policy): provide new contexts and function interfaces for policy engine #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
changed the title
ndr-brt
force-pushed
the
3511-refactor-interfaces
branch
2 times, most recently
from
85fafd7 to
7f9b987
Compare
ndr-brt
force-pushed
the
3511-refactor-interfaces
branch
from
7f9b987 to
5d675ef
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...spi/src/main/java/org/eclipse/edc/policy/engine/spi/DynamicAtomicConstraintRuleFunction.java
Dismissed
Show dismissed
Hide dismissed
...spi/src/main/java/org/eclipse/edc/policy/engine/spi/DynamicAtomicConstraintRuleFunction.java
Dismissed
Show dismissed
Hide dismissed
...spi/src/main/java/org/eclipse/edc/policy/engine/spi/DynamicAtomicConstraintRuleFunction.java
Dismissed
Show dismissed
Hide dismissed
...spi/src/main/java/org/eclipse/edc/policy/engine/spi/DynamicAtomicConstraintRuleFunction.java
Dismissed
Show dismissed
Hide dismissed
jimmarino
reviewed
Oct 14, 2024
| @@ -17,14 +17,15 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation(project(":spi:common:validator-spi")) | |||
| implementation(project(":spi:control-plane:control-plane-spi")) | |||
| api(project(":spi:common:boot-spi")) | |||
There was a problem hiding this comment.
Why are these exposed as APIs? They are not needed to extend this module.
There was a problem hiding this comment.
must have been some rebase/pr split issue, will remove it
ok, gotcha in a core module no need to have api dependencies.
I think we never put down a clear statement on how these needs to be set.
Could it be that only spi modules should expose other spi as api? otherwise implementation
There was a problem hiding this comment.
I think a module should only expose another module as an api if it is transitively exposed to interact with it, e.g. an SPI interface references a type from the other module.
ndr-brt
force-pushed
the
3511-refactor-interfaces
branch
from
0c31c17 to
146a231
Compare
jimmarino
approved these changes
Oct 15, 2024
wolf4ood
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Given that #4535 is really huge, I extracted a smaller PR, that takes care of:
PolicyContextimplementationWhy it does that
help the review process
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Part of #3511
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.