-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Asset/Dataset specialization pt. 2 #4301
feat: implement Asset/Dataset specialization pt. 2 #4301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4301 +/- ##
==========================================
+ Coverage 71.74% 75.20% +3.45%
==========================================
Files 919 1051 +132
Lines 18457 21109 +2652
Branches 1037 1182 +145
==========================================
+ Hits 13242 15875 +2633
+ Misses 4756 4720 -36
- Partials 459 514 +55 ☔ View full report in Codecov by Sentry. |
337998a
to
5019ebf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question inline related to dependencies
What this PR changes/adds
implements the second part of the preparatory work for Management Domains, specifically:
Catalog
extendDataset
DatasetResolver
andDistributionResolver
so that they can handleCatalogAsset
sCatalogAsset
sWhy it does that
Management Domain feature, specifically handling distributed catalogs
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4296
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.