Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Asset/Dataset specialization pt. 2 #4301

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

implements the second part of the preparatory work for Management Domains, specifically:

  • makes Catalog extend Dataset
  • improves the DatasetResolver and DistributionResolver so that they can handle CatalogAssets
  • updates the JSON-LD transformers, so they can handle CatalogAssets

Why it does that

Management Domain feature, specifically handling distributed catalogs

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4296

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request core feature api Feature related to the (REST) api labels Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (7f20ba5) to head (b0c53dc).
Report is 325 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4301      +/-   ##
==========================================
+ Coverage   71.74%   75.20%   +3.45%     
==========================================
  Files         919     1051     +132     
  Lines       18457    21109    +2652     
  Branches     1037     1182     +145     
==========================================
+ Hits        13242    15875    +2633     
+ Misses       4756     4720      -36     
- Partials      459      514      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger force-pushed the feat/4296_asset_specialization_pt2 branch from 337998a to 5019ebf Compare June 24, 2024 12:59
@paullatzelsperger paullatzelsperger marked this pull request as ready for review June 25, 2024 11:41
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question inline related to dependencies

@paullatzelsperger paullatzelsperger merged commit 8956e78 into eclipse-edc:main Jun 25, 2024
22 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/4296_asset_specialization_pt2 branch June 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api core feature enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management Domains: Asset and Dataset specialization pt. 2
5 participants