Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ilike operator for Criterion #4114

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 15, 2024

What this PR changes/adds

Add ilike operator for Criterion

Why it does that

improve query system

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4104

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Apr 15, 2024
@ndr-brt ndr-brt requested a review from wolf4ood April 15, 2024 08:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.75%. Comparing base (7f20ba5) to head (2b4a0f8).
Report is 217 commits behind head on main.

Files Patch % Lines
.../org/eclipse/edc/query/IlikeOperatorPredicate.java 77.77% 1 Missing and 1 partial ⚠️
...lipse/edc/query/CriterionOperatorRegistryImpl.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4114      +/-   ##
==========================================
+ Coverage   71.74%   74.75%   +3.01%     
==========================================
  Files         919      983      +64     
  Lines       18457    20190    +1733     
  Branches     1037     1137     +100     
==========================================
+ Hits        13242    15094    +1852     
+ Misses       4756     4600     -156     
- Partials      459      496      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit 5008004 into eclipse-edc:main Apr 15, 2024
18 checks passed
@ndr-brt ndr-brt deleted the 4104-ilike-operator branch April 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ilike operator for management api
3 participants