Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): run management-api e2e tests with postgresql #3861

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Feb 14, 2024

What this PR changes/adds

Runs management-api e2e tests with postgresql

Why it does that

test coverage

Further notes

  • unfortunately junit does not support parameterization at class level yet so I went with an hacky approach:

    • one interface that define and register the runtime for every persistence type (in memory / postgres)
    • the tests are located in an inner Tests abstract class
    • the "to-be-run" classes extends the Tests class and implements the runtime one.
  • this causes to have static constants for the ports (that needs both to be passed to the runtime and to the tests class. Good enough I'd say.

  • this activity helped find out little flaws in ReflectionUtil and AssetQueryValidator

Linked Issue(s)

Closes #3860

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Feb 14, 2024
@ndr-brt ndr-brt requested a review from wolf4ood February 14, 2024 16:04
@ndr-brt ndr-brt force-pushed the 3860-management-api-postgres branch from d12af86 to f7742e6 Compare February 15, 2024 07:48
@ndr-brt ndr-brt merged commit b8d1af9 into eclipse-edc:main Feb 15, 2024
17 checks passed
@ndr-brt ndr-brt deleted the 3860-management-api-postgres branch February 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test management-api with postgresql
2 participants