feat: add prefix monitor #3621
Merged
feat: add prefix monitor #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidonos
added
enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
===========================================
- Coverage 71.77% 17.27% -54.51%
===========================================
Files 909 910 +1
Lines 18104 18126 +22
Branches 1027 1027
===========================================
- Hits 12994 3131 -9863
- Misses 4666 14908 +10242
+ Partials 444 87 -357 ☔ View full report in Codecov by Sentry. |
jimmarino
requested changes
Nov 16, 2023
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/PrefixMonitor.java
Outdated
Show resolved
Hide resolved
...nitor/monitor-jdk-logger/src/test/java/org/eclipse/edc/monitor/logger/PrefixMonitorTest.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/PrefixMonitor.java
Outdated
Show resolved
Hide resolved
ndr-brt
requested changes
Nov 16, 2023
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/Monitor.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/PrefixMonitor.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/PrefixMonitor.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/PrefixMonitor.java
Outdated
Show resolved
Hide resolved
...nitor/monitor-jdk-logger/src/test/java/org/eclipse/edc/monitor/logger/PrefixMonitorTest.java
Outdated
Show resolved
Hide resolved
...nitor/monitor-jdk-logger/src/test/java/org/eclipse/edc/monitor/logger/PrefixMonitorTest.java
Outdated
Show resolved
Hide resolved
...nitor/monitor-jdk-logger/src/test/java/org/eclipse/edc/monitor/logger/PrefixMonitorTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Nov 21, 2023
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/monitor/Monitor.java
Show resolved
Hide resolved
|
Please resolve the outstanding comments and dependency review. Thx. |
jimmarino
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This will add a new monitor implementation so that logs can be prefixed with a custom string.
Why it does that
Give logs more meaning by providing a context.
Further notes
Linked Issue(s)
Closes #3510