Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved IATP model classes up from IdentityHub #3612

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR moves most of the commonly used IATP model classes up into EDC from the IdentityHub. Most notably:

  • model classes that are used to query the CredentialServce (=IdentityHub)
  • Transformers for the model classes
  • constants

Why it does that

The model classes will be shared by the connector and IdentityHub

Further notes

  • This PR does not introduce any functional changes, only moves classes from one repo to another
  • once this PR is merged, the classes will be deleted from IdentityHub

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added this to the Milestone 13 milestone Nov 15, 2023
@paullatzelsperger paullatzelsperger added core feature refactoring Cleaning up code and dependencies api Feature related to the (REST) api dcp labels Nov 15, 2023
@paullatzelsperger paullatzelsperger force-pushed the chore/upstream_iatp_model_classes_from_identityhub branch from 93e2c56 to 06253a4 Compare November 15, 2023 14:46
@codecov-commenter
Copy link

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (5b13175) 72.11% compared to head (06253a4) 71.74%.

Files Patch % Lines
...ntitytrust/model/presentationdefinition/Field.java 0.00% 24 Missing ⚠️
.../model/presentationdefinition/InputDescriptor.java 0.00% 23 Missing ⚠️
...presentationdefinition/PresentationDefinition.java 0.00% 21 Missing ⚠️
...ust/model/credentialservice/PresentationQuery.java 0.00% 16 Missing ⚠️
...m/to/JsonObjectToPresentationQueryTransformer.java 63.15% 5 Missing and 2 partials ⚠️
.../identitytrust/core/IdentityAndTrustExtension.java 0.00% 2 Missing ⚠️
.../model/credentialservice/PresentationResponse.java 0.00% 1 Missing ⚠️
...rust/model/presentationdefinition/Constraints.java 0.00% 1 Missing ⚠️
...model/presentationdefinition/FilterExpression.java 0.00% 1 Missing ⚠️
...titytrust/model/presentationdefinition/Format.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   72.11%   71.74%   -0.37%     
==========================================
  Files         898      909      +11     
  Lines       17973    18084     +111     
  Branches     1021     1021              
==========================================
+ Hits        12961    12975      +14     
- Misses       4571     4666      +95     
- Partials      441      443       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paullatzelsperger paullatzelsperger merged commit 1a92799 into eclipse-edc:main Nov 15, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api core feature dcp refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants