refactor(api): counterPartyAddress #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sascha Isele <[email protected]>
saschaisele-zf
changed the title
jimmarino
requested changes
Nov 10, 2023
...tor/api/management/contractnegotiation/transform/JsonObjectToContractRequestTransformer.java
Show resolved
Hide resolved
...se/edc/connector/api/management/contractnegotiation/validation/ContractRequestValidator.java
Show resolved
Hide resolved
...clipse/edc/connector/api/management/transferprocess/validation/TransferRequestValidator.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3597 +/- ##
=======================================
Coverage 72.09% 72.10%
=======================================
Files 897 897
Lines 17920 17949 +29
Branches 1018 1024 +6
=======================================
+ Hits 12920 12942 +22
- Misses 4563 4568 +5
- Partials 437 439 +2
☔ View full report in Codecov by Sentry. |
|
Added a note in the review: we need to discuss when to introduce this change due to DSP backward-compatibility issues. |
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
saschaisele-zf
changed the title
ndr-brt
requested changes
Nov 13, 2023
There was a problem hiding this comment.
just minor comments about the warning messages.
@jimmarino I think this PR is not a breaking change (everything will work in the same way), the break part of the change will happen when we'll remove the old attributes. I don't see change in the DSP protocol either
...se/edc/connector/api/management/contractnegotiation/validation/ContractRequestValidator.java
Show resolved
Hide resolved
...nnector/api/management/transferprocess/transform/JsonObjectToTransferRequestTransformer.java
Outdated
Show resolved
Hide resolved
ndr-brt
added
refactoring
Signed-off-by: Sascha Isele <[email protected]>
Signed-off-by: Sascha Isele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Deprecates the remaining uses of
connectorAddressandproviderUrlin theContractNegotiationApiandTransferProcessApi.Instead,
counterPartyAddressis used going forward.Why it does that
Use of consistent naming across the management api.
Further notes
It is important to note that this is a breaking change.
CAUTION ADVICED WHEN MERGING.
Linked Issue(s)
Closes #3343
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.