-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IATP): pluggable constraint to scope mapping #3593
Merged
wolf4ood
merged 2 commits into
eclipse-edc:main
from
wolf4ood:feat/3492_derive_scope_from_credential
Nov 10, 2023
Merged
feat(IATP): pluggable constraint to scope mapping #3593
wolf4ood
merged 2 commits into
eclipse-edc:main
from
wolf4ood:feat/3492_derive_scope_from_credential
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/3492_derive_scope_from_credential
branch
2 times, most recently
from
November 7, 2023 08:23
c3f5ca1
to
1e74434
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3593 +/- ##
==========================================
+ Coverage 72.00% 72.09% +0.09%
==========================================
Files 893 897 +4
Lines 17855 17920 +65
Branches 1015 1018 +3
==========================================
+ Hits 12856 12920 +64
- Misses 4562 4563 +1
Partials 437 437
☔ View full report in Codecov by Sentry. |
wolf4ood
force-pushed
the
feat/3492_derive_scope_from_credential
branch
from
November 7, 2023 08:56
1e74434
to
e9745cc
Compare
wolf4ood
force-pushed
the
feat/3492_derive_scope_from_credential
branch
from
November 7, 2023 09:06
e9745cc
to
7cbd0ea
Compare
wolf4ood
changed the title
feat: pluggable constraint to scope mapping
feat(IATP): pluggable constraint to scope mapping
Nov 7, 2023
...mon/identity-trust-spi/src/main/java/org/eclipse/edc/identitytrust/scope/ScopeExtractor.java
Show resolved
Hide resolved
...t-core/src/main/java/org/eclipse/edc/iam/identitytrust/core/IatpScopeExtractorExtension.java
Outdated
Show resolved
Hide resolved
...t-core/src/main/java/org/eclipse/edc/iam/identitytrust/core/IatpScopeExtractorExtension.java
Outdated
Show resolved
Hide resolved
jimmarino
approved these changes
Nov 8, 2023
paullatzelsperger
approved these changes
Nov 8, 2023
bscholtes1A
reviewed
Nov 8, 2023
...t-core/src/main/java/org/eclipse/edc/iam/identitytrust/core/IatpScopeExtractorExtension.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add pluggable constraints to scope mapping:
ScopeExtractorRegistry
for registering custom extractors.IatpScopeExtractorFunction
and register it as pre-validator in the policy engine for invoking estractors in the registry and map the result in thescope
ScopeExtractor
for now are not tied to a specificscope
orrule
.Why it does that
iatp adoption
Linked Issue(s)
Closes #3492
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.