Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Decouple core modules #3586

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

jimmarino
Copy link
Contributor

Decouples:

  • catalog-spi from control-plane:contract-spi
  • control-plane-spi from web-spi

By moving ContractOffer and ContractAgreement from contract-spi to core-spi.

Linked Issue(s)

Closes #3585

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Nov 1, 2023
@jimmarino jimmarino requested review from wolf4ood and bscholtes1A and removed request for ndr-brt, paullatzelsperger, juliapampus and ronjaquensel November 1, 2023 13:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5dcd530) 72.24% compared to head (0819112) 4.77%.

❗ Current head 0819112 differs from pull request most recent head 8e688d8. Consider uploading reports for the commit 8e688d8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #3586       +/-   ##
============================================
- Coverage     72.24%   4.77%   -67.47%     
- Complexity        0     243      +243     
============================================
  Files           893     893               
  Lines         17855   17855               
  Branches       1015    1015               
============================================
- Hits          12899     853    -12046     
- Misses         4518   16982    +12464     
+ Partials        438      20      -418     
Files Coverage Δ
...ector/core/policy/ContractExpiryCheckFunction.java 0.00% <ø> (-77.28%) ⬇️
...iation/ConsumerContractNegotiationManagerImpl.java 0.00% <ø> (-100.00%) ⬇️
...iation/ProviderContractNegotiationManagerImpl.java 0.00% <ø> (-100.00%) ⬇️
...c/connector/contract/policy/PolicyArchiveImpl.java 0.00% <ø> (-100.00%) ⬇️
...ract/validation/ContractValidationServiceImpl.java 0.00% <ø> (-86.12%) ⬇️
...ontractagreement/ContractAgreementServiceImpl.java 0.00% <ø> (-84.62%) ⬇️
...actnegotiation/ContractNegotiationServiceImpl.java 0.00% <ø> (-100.00%) ⬇️
...tnegotiation/InMemoryContractNegotiationStore.java 0.00% <ø> (-88.89%) ⬇️
...licy/monitor/manager/PolicyMonitorManagerImpl.java 0.00% <ø> (-92.73%) ⬇️
...onObjectToContractAgreementMessageTransformer.java 0.00% <ø> (-62.50%) ⬇️
... and 20 more

... and 635 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino jimmarino merged commit 7c424e5 into eclipse-edc:main Nov 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: decouple more SPI modules
4 participants