-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: permit query Asset
json properties
#3559
Conversation
4c48e4f
to
efcea29
Compare
var openingBracketIx = first.toString().indexOf(OPENING_BRACKET); | ||
var closingBracketIx = first.toString().indexOf(CLOSING_BRACKET); | ||
var propName = first.toString().substring(0, openingBracketIx); | ||
var arrayIndex = Integer.parseInt(first.toString().substring(openingBracketIx + 1, closingBracketIx)); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
832f658
to
4169f68
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3559 +/- ##
===========================================
- Coverage 72.49% 17.55% -54.94%
===========================================
Files 877 879 +2
Lines 17474 17410 -64
Branches 994 988 -6
===========================================
- Hits 12667 3056 -9611
- Misses 4391 14267 +9876
+ Partials 416 87 -329
☔ View full report in Codecov by Sentry. |
4169f68
to
f5b05ac
Compare
f5b05ac
to
7be0a83
Compare
The segments of |
yes, it must be extended, because it is a simple "value", not an "id" |
What this PR changes/adds
Permits to query over nested properties in Asset.
To do that, the notation should be, e.g.:
to navigate through the property tree, the wrapping
'
are needed to clearly separate path items (because keys could contain the.
).Current behavior without wrapping
'
for a not nested property is still valid.Why it does that
fix bug
Further notes
asset-index-sql
extension README to get migration instructions.updateDataAddress
method fromAssetService
Linked Issue(s)
Closes #3423
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.