feat: add multi-format VP/VC verifier #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ust-core/src/main/java/org/eclipse/edc/iam/identitytrust/core/IdentityAndTrustExtension.java
Show resolved
Hide resolved
...ce/src/main/java/org/eclipse/edc/iam/identitytrust/verification/JwtPresentationVerifier.java
Fixed
Show fixed
Hide fixed
...-trust-service/src/main/java/org/eclipse/edc/iam/identitytrust/verification/LdpVerifier.java
Fixed
Show fixed
Hide fixed
Test Results 625 files + 4 625 suites +4 18m 16s ⏱️ -35s Results for commit 7af34e4. ± Comparison against base commit cba9558. This pull request removes 110 and adds 145 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
- Coverage 72.49% 72.27% -0.22%
==========================================
Files 877 880 +3
Lines 17474 17687 +213
Branches 994 1019 +25
==========================================
+ Hits 12667 12784 +117
- Misses 4391 4466 +75
- Partials 416 437 +21
☔ View full report in Codecov by Sentry. |
paullatzelsperger
force-pushed
the
feat/3533_verify_consumer_ldp-vp-vc
branch
8 times, most recently
from
30fe45f to
2ed8214
Compare
paullatzelsperger
force-pushed
the
feat/3533_verify_consumer_ldp-vp-vc
branch
2 times, most recently
from
24845a5 to
f0498cb
Compare
bscholtes1A
reviewed
Oct 23, 2023
...t-service/src/main/java/org/eclipse/edc/iam/identitytrust/validation/rules/IsNotExpired.java
Outdated
Show resolved
Hide resolved
...-credentials/src/main/java/org/eclipse/edc/verifiablecredentials/linkeddata/LdpVerifier.java
Outdated
Show resolved
Hide resolved
...tials/src/main/java/org/eclipse/edc/verifiablecredentials/jwt/SelfIssuedIdTokenVerifier.java
Outdated
Show resolved
Hide resolved
...entials/src/main/java/org/eclipse/edc/verifiablecredentials/jwt/JwtPresentationVerifier.java
Outdated
Show resolved
Hide resolved
...entity-trust-spi/src/main/java/org/eclipse/edc/identitytrust/model/VerifiableCredential.java
Outdated
Show resolved
Hide resolved
...y-trust-spi/src/main/java/org/eclipse/edc/identitytrust/verification/CredentialVerifier.java
Show resolved
Hide resolved
bscholtes1A
reviewed
Oct 24, 2023
...entials/src/main/java/org/eclipse/edc/verifiablecredentials/jwt/JwtPresentationVerifier.java
Outdated
Show resolved
Hide resolved
added LDP verifier, added SignatureSuiteRegistry to host multiple SignatureSuites, made the TestDocumentLoader more generally available, BREAKING CHANGE: the TestResourceLoader was renamed to TestDocumentLoader, and moved
paullatzelsperger
force-pushed
the
feat/3533_verify_consumer_ldp-vp-vc
branch
from
a32887b to
7af34e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds a verifier structure, which can verify
ldp_vp,ldp_vc,jwt_vpandjwt_vcobjects by using a flexible delegate mechanism. It is possible to mix-and-match them, for example one could have:NB: according to their schema, LDP-VPs can only contain LDP-VCs, even if the spec doesn't really mandate that.
Why it does that
Being able to handle different formats of VPs, and different formats of VCs.
Further notes
Due to shortcomings in its implementation I abandoned the
VerifierAPI of theiron-verifiable-credentialslibrary (for LDP), for example, i doesn't properly handle multiple VCs in a presentation. Instead, I re-implemented the same behaviour in the EDC code base.Ultimately, I want to get rid of the
iron-verifiable-credentialslib altogether, but that will require some more work in the following areas:These endeavors will happen in subsequent PRs, once the basic functionality is there.
Linked Issue(s)
Closes #3533
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.