feat: IATP: STS core services #3551
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3551 +/- ##
==========================================
+ Coverage 72.43% 72.49% +0.06%
==========================================
Files 871 877 +6
Lines 17394 17474 +80
Branches 988 994 +6
==========================================
+ Hits 12599 12668 +69
- Misses 4379 4390 +11
Partials 416 416
☔ View full report in Codecov by Sentry. |
wolf4ood
force-pushed
the
feat/3550_sts_core_services
branch
3 times, most recently
from
6d84803 to
0698b75
Compare
wolf4ood
force-pushed
the
feat/3550_sts_core_services
branch
10 times, most recently
from
01b1e0e to
cc1e5a0
Compare
| @Override | ||
| public Result<TokenRepresentation> generate(@NotNull JwtDecorator... decorators) { | ||
| var key = privateKeyResolver.resolvePrivateKey(keyAlias, PrivateKey.class); | ||
| return new TokenGenerationServiceImpl(key).generate(decorators); |
There was a problem hiding this comment.
Looks a bit convoluted...
Could we modify the current TokenGenerationService that it does not take directly a private key in the ctor, but instead a Function<String,PrivateKey> (the input string being the alias)?
There was a problem hiding this comment.
That's a refactor that i would do later, if i change the TokenGenerationServiceImpl not i might end up changing a lot of files :)
I would raise an issue and address this in another PR wdyt?
There was a problem hiding this comment.
Agreed, it would be good to look at simplifying this in a separate PR
...re/src/main/java/org/eclipse/edc/iam/identitytrust/sts/core/StsDefaultServicesExtension.java
Show resolved
Hide resolved
wolf4ood
force-pushed
the
feat/3550_sts_core_services
branch
from
76e1e74 to
61fbb4f
Compare
wolf4ood
force-pushed
the
feat/3550_sts_core_services
branch
from
61fbb4f to
da1fb7a
Compare
.../src/main/java/org/eclipse/edc/iam/identitytrust/sts/service/StsTokenGenerationProvider.java
Show resolved
Hide resolved
core/common/jwt-core/src/main/java/org/eclipse/edc/jwt/LazyTokenGenerationService.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public Result<TokenRepresentation> generate(@NotNull JwtDecorator... decorators) { | ||
| var key = privateKeyResolver.resolvePrivateKey(keyAlias, PrivateKey.class); | ||
| return new TokenGenerationServiceImpl(key).generate(decorators); |
There was a problem hiding this comment.
Agreed, it would be good to look at simplifying this in a separate PR
...ipse/edc/iam/identitytrust/sts/core/defaults/service/StsClientTokenGeneratorServiceImpl.java
Outdated
Show resolved
Hide resolved
...ipse/edc/iam/identitytrust/sts/core/defaults/service/StsClientTokenGeneratorServiceImpl.java
Outdated
Show resolved
Hide resolved
What this PR changes/adds
Implements STS core services specifically
STS-SPI
Added module
:spi:common:identity-trust-sts-spifor sts specific interfaces and models:StsClient: modeling the clients in STSStsClientService: Service layer for StsClientsStsClientStore: Persistence layer for StsClients.StsClientTokenGeneratorService: Token generator forStsClientsSTS-Core
Added module
:extensions:common:iam:identity-trust:identity-trust-sts-corewith the default implementationof the
sts-spiservices.Why it does that
iatp adoption
Further notes
And additional token generation service has been implemented
LazyTokenGenerationServiceto be able to work with non cached keys.Linked Issue(s)
Closes #3550