Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get rid of cid claim in EndpointDataReference auth token #3541

Merged

Conversation

bscholtes1A
Copy link
Contributor

What this PR changes/adds

Remove cid claim from auth token generated for EndpointDataReference

Why it does that

Avoid conflict when cid claim is already used.

Linked Issue(s)

Closes #3478

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@bscholtes1A bscholtes1A added the enhancement New feature or request label Oct 13, 2023
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, but as issue #3478 states, it will be a breaking change, and thus we should merge this close to the next milestone release (0.4.0), which is scheduled for Nov 13.
The reason being is, that if we have to release a bugfix version in the meantime, that would already contain that breaking change.

@bscholtes1A
Copy link
Contributor Author

all good, but as issue #3478 states, it will be a breaking change, and thus we should merge this close to the next milestone release (0.4.0), which is scheduled for Nov 13. The reason being is, that if we have to release a bugfix version in the meantime, that would already contain that breaking change.

No problem I'll keep it up-to-date until the release

@bscholtes1A bscholtes1A changed the title feat: get rid of cid claim in EndpointDataReference auth token [DO NOT MERGE] feat: get rid of cid claim in EndpointDataReference auth token Oct 18, 2023
@github-actions
Copy link

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Oct 26, 2023
Copy link

github-actions bot commented Nov 2, 2023

This pull request was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Nov 2, 2023
@wolf4ood wolf4ood reopened this Nov 2, 2023
@wolf4ood wolf4ood removed the stale Open for x days with no activity label Nov 2, 2023
@bscholtes1A bscholtes1A force-pushed the feat/edr_token_get_rid_of_cid_claim branch from c1e7739 to e480471 Compare November 2, 2023 09:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c424e5) 72.00% compared to head (e480471) 64.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   72.00%   64.25%   -7.75%     
==========================================
  Files         893      892       -1     
  Lines       17855    17842      -13     
  Branches     1015     1013       -2     
==========================================
- Hits        12856    11465    -1391     
- Misses       4562     5975    +1413     
+ Partials      437      402      -35     
Files Coverage Δ
...sfer/dataplane/TransferDataPlaneCoreExtension.java 81.81% <ø> (-0.80%) ⬇️
...lane/proxy/ConsumerPullDataPlaneProxyResolver.java 100.00% <100.00%> (ø)
...roxy/ConsumerPullDataPlaneProxyTokenDecorator.java 100.00% <100.00%> (ø)

... and 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bscholtes1A bscholtes1A changed the title [DO NOT MERGE] feat: get rid of cid claim in EndpointDataReference auth token feat: get rid of cid claim in EndpointDataReference auth token Nov 2, 2023
Copy link

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Nov 14, 2023
@ndr-brt ndr-brt added breaking-change Will require manual intervention for version update and removed stale Open for x days with no activity labels Nov 14, 2023
@ndr-brt ndr-brt merged commit 9d472cf into eclipse-edc:main Nov 15, 2023
21 of 22 checks passed
tuncaytunc-zf pushed a commit to tuncaytunc-zf/DataSpaceConnector that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDR: Remove usage of the cid field
5 participants