-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get rid of cid
claim in EndpointDataReference
auth token
#3541
feat: get rid of cid
claim in EndpointDataReference
auth token
#3541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, but as issue #3478 states, it will be a breaking change, and thus we should merge this close to the next milestone release (0.4.0), which is scheduled for Nov 13.
The reason being is, that if we have to release a bugfix version in the meantime, that would already contain that breaking change.
No problem I'll keep it up-to-date until the release |
cid
claim in EndpointDataReference
auth tokencid
claim in EndpointDataReference
auth token
This pull request is stale because it has been open for 7 days with no activity. |
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
c1e7739
to
e480471
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
==========================================
- Coverage 72.00% 64.25% -7.75%
==========================================
Files 893 892 -1
Lines 17855 17842 -13
Branches 1015 1013 -2
==========================================
- Hits 12856 11465 -1391
- Misses 4562 5975 +1413
+ Partials 437 402 -35
☔ View full report in Codecov by Sentry. |
cid
claim in EndpointDataReference
auth tokencid
claim in EndpointDataReference
auth token
This pull request is stale because it has been open for 7 days with no activity. |
…clipse-edc#3541) feat: get rid of cid claim in EDR auth token
What this PR changes/adds
Remove
cid
claim from auth token generated forEndpointDataReference
Why it does that
Avoid conflict when
cid
claim is already used.Linked Issue(s)
Closes #3478
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.