feat: stop policy monitor job when transfer is already completed/terminated #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
wolf4ood,
jimmarino,
paullatzelsperger and
bscholtes1A
jimmarino
approved these changes
Oct 9, 2023
ndr-brt
force-pushed
the
3506-complete-policy-monitor
branch
from
6c9daad to
f488ce7
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3520 +/- ##
==========================================
- Coverage 72.07% 72.06% -0.01%
==========================================
Files 848 848
Lines 17092 17102 +10
Branches 958 960 +2
==========================================
+ Hits 12319 12325 +6
- Misses 4366 4369 +3
- Partials 407 408 +1
☔ View full report in Codecov by Sentry. |
wolf4ood
approved these changes
Oct 9, 2023
paullatzelsperger
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Check the
TransferProcessstate on every iteration, if it is completed/terminated/deprovisioned by other processes or user actions, move thePolicyMonitorEntrytoCOMPLETEDWhy it does that
policy monitor
Further notes
Linked Issue(s)
Closes #3506
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.