Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define policy.monitor policy scope #3518

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 6, 2023

What this PR changes/adds

Define a new policy.monitor scope that will be used by the policy monitor, on which the ContractExpiryCheckFunction is defined by default

Why it does that

policy monitor

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #3482

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request policy labels Oct 6, 2023
@ndr-brt ndr-brt force-pushed the 3482-define-policymonitor-scope branch from c5e8029 to 4457f62 Compare October 6, 2023 13:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9d39f5c) 72.07% compared to head (3622e61) 72.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3518      +/-   ##
==========================================
+ Coverage   72.07%   72.18%   +0.11%     
==========================================
  Files         848      848              
  Lines       17092    17095       +3     
  Branches      958      958              
==========================================
+ Hits        12319    12340      +21     
+ Misses       4366     4348      -18     
  Partials      407      407              
Files Coverage Δ
...ector/core/policy/ContractExpiryCheckFunction.java 77.27% <ø> (ø)
.../edc/connector/contract/ContractCoreExtension.java 84.84% <ø> (ø)
...nnector/policy/monitor/PolicyMonitorExtension.java 80.76% <100.00%> (+80.76%) ⬆️
...licy/monitor/manager/PolicyMonitorManagerImpl.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 3482-define-policymonitor-scope branch from 4457f62 to 3622e61 Compare October 6, 2023 13:54
@ndr-brt ndr-brt merged commit beca927 into eclipse-edc:main Oct 9, 2023
16 checks passed
@ndr-brt ndr-brt deleted the 3482-define-policymonitor-scope branch October 9, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

policy-monitor: define custom policy scope
3 participants