feat: create model transformers for VC and VP #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ust-spi/src/main/java/org/eclipse/edc/identitytrust/model/VerifiableCredentialContainer.java
Dismissed
Show dismissed
Hide dismissed
| * This container object is intended to hold a {@link VerifiableCredential}, its raw representation and which format it is in. | ||
| * | ||
| * @param rawVc A String containing the VC in its raw format. This must be exactly how it was originally received by the issuer. | ||
| * @param format indicates whether the VC is present in JWT or JSON-LD format |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
...ust-spi/src/main/java/org/eclipse/edc/identitytrust/model/VerifiableCredentialContainer.java
Dismissed
Show dismissed
Hide dismissed
paullatzelsperger
force-pushed
the
feat/3501_create_iatp_model_transformers
branch
from
8f1c086 to
b52b228
Compare
paullatzelsperger
changed the title
bscholtes1A
reviewed
Oct 5, 2023
...ansform/src/main/java/org/eclipse/edc/iam/identitytrust/IdentityTrustTransformExtension.java
Outdated
Show resolved
Hide resolved
...tity-trust-spi/src/main/java/org/eclipse/edc/identitytrust/model/VerifiablePresentation.java
Show resolved
Hide resolved
| /** | ||
| * This container object is intended to hold a {@link VerifiableCredential}, its raw representation and which format it is in. | ||
| * | ||
| * @param rawVp A String containing the VP in its raw format. This must be exactly how it was originally received by the holder. |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
| * This container object is intended to hold a {@link VerifiableCredential}, its raw representation and which format it is in. | ||
| * | ||
| * @param rawVp A String containing the VP in its raw format. This must be exactly how it was originally received by the holder. | ||
| * @param format indicates whether the VP is present in JWT or JSON-LD format |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
| * | ||
| * @param rawVp A String containing the VP in its raw format. This must be exactly how it was originally received by the holder. | ||
| * @param format indicates whether the VP is present in JWT or JSON-LD format | ||
| * @param credential the {@link VerifiablePresentation}, as it was deserialized from the raw VP string. Note that JSON-LD and JWT VCs |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3515 +/- ##
==========================================
- Coverage 72.10% 72.06% -0.04%
==========================================
Files 832 839 +7
Lines 16947 17017 +70
Branches 954 956 +2
==========================================
+ Hits 12220 12264 +44
- Misses 4323 4346 +23
- Partials 404 407 +3
☔ View full report in Codecov by Sentry. |
bscholtes1A
approved these changes
Oct 6, 2023
wolf4ood
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds transformers that can convert JSON-LD ->
VerifiableCredentialandVerifiablePresentation.Why it does that
Preliminary work needed for subsequent IATP adoption tasks.
Further notes
VerifiableCredentialitself does not hold the raw VC anymoreVerifiableCredentialContainer(name is up for discussion), that stores the raw VC (JWT or JSON-LD), the credential format and the deserializedVerifiableCredentialinstance.Linked Issue(s)
Closes #3501
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.