Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PolicyMonitorStore SQL implementation #3505

Closed

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 3, 2023

What this PR changes/adds

Provide sql implementation for PolicyManagerStore

Why it does that

policy-manager

Further notes

  • refactored in-memory stores and statements to avoid duplication

Linked Issue(s)

Closes #3447

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt requested a review from wolf4ood October 3, 2023 13:50
return "edc_policy_monitor";
}

default String getIdColumn() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [StatefulEntityStatements.getIdColumn](1); it is advisable to add an Override annotation.

default String getErrorDetailColumn() {
return "error_detail";
default String getIdColumn() {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [StatefulEntityStatements.getIdColumn](1); it is advisable to add an Override annotation.
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (8caa6e0) 72.03% compared to head (a00626f) 72.03%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3505      +/-   ##
==========================================
- Coverage   72.03%   72.03%   -0.01%     
==========================================
  Files         834      843       +9     
  Lines       16896    16994      +98     
  Branches      948      951       +3     
==========================================
+ Hits        12171    12241      +70     
- Misses       4320     4347      +27     
- Partials      405      406       +1     
Files Coverage Δ
...on/store/schema/ContractNegotiationStatements.java 100.00% <ø> (ø)
...re/schema/postgres/ContractNegotiationMapping.java 100.00% <100.00%> (ø)
...s/store/schema/TransferProcessStoreStatements.java 100.00% <100.00%> (ø)
.../store/schema/postgres/TransferProcessMapping.java 100.00% <100.00%> (ø)
...nnector/dataplane/store/sql/SqlDataPlaneStore.java 90.81% <100.00%> (ø)
...e/store/sql/schema/BaseSqlDataPlaneStatements.java 100.00% <ø> (+2.27%) ⬆️
...ataplane/store/sql/schema/DataPlaneStatements.java 100.00% <ø> (ø)
...ne/store/sql/schema/postgres/DataPlaneMapping.java 100.00% <100.00%> (ø)
...ore/sql/schema/BaseSqlPolicyMonitorStatements.java 100.00% <100.00%> (ø)
...monitor/store/sql/schema/PolicyMonitorMapping.java 100.00% <100.00%> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt added the enhancement New feature or request label Oct 4, 2023
@ndr-brt ndr-brt force-pushed the 3447-policymonitor-postgres branch from 915c7be to 5e0856e Compare October 4, 2023 06:16
@ndr-brt ndr-brt force-pushed the 3447-policymonitor-postgres branch from 5e0856e to c9eb925 Compare October 4, 2023 07:05
@ndr-brt
Copy link
Member Author

ndr-brt commented Oct 4, 2023

for some reasons I cannot push on the branch anymore, will open the pr again on another one

@ndr-brt ndr-brt closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

policy-monitor: sql storage
2 participants