Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IdResponse on addEntry API #3449

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

Returns IdResponse in the POST /v2/dataplanes API.

Why it does that

consistency

Linked Issue(s)

Closes #3352

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@wolf4ood wolf4ood self-assigned this Sep 13, 2023
@wolf4ood wolf4ood added api Feature related to the (REST) api enhancement New feature or request labels Sep 13, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (f467cff) 71.95% compared to head (356f52d) 71.97%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
+ Coverage   71.95%   71.97%   +0.02%     
==========================================
  Files         837      837              
  Lines       17012    17018       +6     
  Branches      948      948              
==========================================
+ Hits        12241    12249       +8     
+ Misses       4366     4364       -2     
  Partials      405      405              
Files Changed Coverage Δ
...aplane/selector/DataPlaneSelectorApiExtension.java 100.00% <100.00%> (ø)
...elector/api/v2/DataplaneSelectorApiController.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/3352_id_in_dataplanes branch from 356f52d to 99b3a5c Compare September 13, 2023 11:39
@wolf4ood wolf4ood marked this pull request as ready for review September 13, 2023 12:01
@wolf4ood wolf4ood merged commit 46d578c into eclipse-edc:main Sep 13, 2023
@wolf4ood wolf4ood deleted the feat/3352_id_in_dataplanes branch September 13, 2023 12:51
ndkrimbacher pushed a commit to nexyo-io/DataSpaceConnector that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make POST /v2/dataplanes return IdResponse
4 participants