feat: add dataset endpoint management api #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
requested review from
paullatzelsperger,
ronjaquensel and
juliapampus
as code owners
ndr-brt
force-pushed
the
3281-add-dataset-endpoint-management-api
branch
from
08425b3 to
96108a3
Compare
ndr-brt
force-pushed
the
3281-add-dataset-endpoint-management-api
branch
3 times, most recently
from
928c897 to
a8ab164
Compare
ndr-brt
force-pushed
the
3281-add-dataset-endpoint-management-api
branch
from
a8ab164 to
2568aaf
Compare
jimmarino
approved these changes
Aug 1, 2023
...ttp-core/src/main/java/org/eclipse/edc/protocol/dsp/dispatcher/GetDspHttpRequestFactory.java
Show resolved
Hide resolved
...tp-core/src/main/java/org/eclipse/edc/protocol/dsp/dispatcher/PostDspHttpRequestFactory.java
Show resolved
Hide resolved
wolf4ood
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add
/dataset/requestendpoint on management apiWhy it does that
permit dataset fetch from the clients.
Further notes
CatalogRequestto the standard, renamingproviderUrltocounterPartyAddressas it was done pretty much in all the codebase, this needs to be done to the other APIs as well (renameproviderUrlandconnectorAddresstocounterPartyAddresson management api #3343). This was done deprecatingproviderUrlto avoid breaking changes.DspHttpRequestFactorycomponent, that moved the request creation responsibility away from the "delegate", going towards composition over extension. This could be done also on the "response" side, removing that abstract delegate at all and avoiding some duplication as well. (get rid ofDspHttpDispatcherDelegate#3344)Linked Issue(s)
Closes #3281
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.