feat: introduce typed transformation problem reporting #3004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
In an effort to make transformation problem reporting consistent across the codebase, this PR introduces the
PoblemBuilder
, which provides a way to construct transformation problems in a typed way.Specifically,
TransformationContext
now includes aproblem()
method that returns aProblemBuilder.
The build can be used to report transformation errors:The builder will then construct the problem string and report it to the context. Different categories of problems can be reported: MISSING PROPERTY, NULL PROPERTY, INVALID PROPERTY, UNEXPECTED TYPE.
All transformers have been updated to use this typed access. Only a few, specialized cases use the existing
reportProblem(String problem)
method.This PR also fixes a few bugs in the transformers encountered when updated to typed problem reporting.
Linked Issue(s)
Closes #2909
Checklist
no-changelog
)