refactor: adapt CN states names to the DSP specification #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
ndr-brt
requested review from
paullatzelsperger,
juliapampus and
ronjaquensel
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -39,7 +39,7 @@ | |||
| /** | |||
| * The negotiation has been agreed by the provider. | |||
| */ | |||
| StatusResult<ContractNegotiation> providerAgreed(ClaimToken token, String negotiationId, ContractAgreement agreement, Policy policy); | |||
| StatusResult<ContractNegotiation> agreed(ClaimToken token, String negotiationId, ContractAgreement agreement, Policy policy); | |||
Check notice
Code scanning / CodeQL
Useless parameter
ndr-brt
force-pushed
the
2659-rename-cn-states
branch
from
e63fad7 to
18b2db3
Compare
jimmarino
approved these changes
Apr 4, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2678 +/- ##
==========================================
- Coverage 64.57% 64.57% -0.01%
==========================================
Files 920 920
Lines 18896 18894 -2
Branches 1146 1146
==========================================
- Hits 12202 12200 -2
Misses 6245 6245
Partials 449 449
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Rename states and related methods as done in International-Data-Spaces-Association/ids-specification#71
Why it does that
being aligned with DSP specification
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #2659
Checklist
no-changelog)