Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): new event dispatch on state changes #2622

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Mar 22, 2023

What this PR changes/adds

Add missing event dispatch on state changes

Why it does that

dataspace protocol implementation

Further notes

  • renamed transition methods on ContractNegotiation and TransferProcess to match with the actual DSP states
  • introduced parameterized tests for dispatch failure both for CN and TP managers. This cleaned up the test classes a lot.

Linked Issue(s)

Closes #2603

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Mar 22, 2023
@ndr-brt ndr-brt temporarily deployed to Azure-dev March 22, 2023 12:00 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 73.82% and project coverage change: -0.09 ⚠️

Comparison is base (8a34f0a) 64.52% compared to head (753751d) 64.43%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2622      +/-   ##
==========================================
- Coverage   64.52%   64.43%   -0.09%     
==========================================
  Files         891      894       +3     
  Lines       18276    18302      +26     
  Branches     1087     1084       -3     
==========================================
+ Hits        11792    11793       +1     
- Misses       6050     6080      +30     
+ Partials      434      429       -5     
Impacted Files Coverage Δ
...act/listener/ContractNegotiationEventListener.java 6.66% <0.00%> (-1.34%) ⬇️
...tractnegotiation/ContractNegotiationConfirmed.java 100.00% <ø> (ø)
...gotiation/ContractNegotiationConsumerVerified.java 0.00% <0.00%> (ø)
...ntractnegotiation/ContractNegotiationDeclined.java 100.00% <ø> (ø)
...contractnegotiation/ContractNegotiationFailed.java 100.00% <ø> (ø)
...negotiation/ContractNegotiationProviderAgreed.java 0.00% <0.00%> (ø)
...otiation/ContractNegotiationProviderFinalized.java 0.00% <0.00%> (ø)
...gotiation/observe/ContractNegotiationListener.java 0.00% <0.00%> (ø)
...act/spi/types/negotiation/ContractNegotiation.java 0.00% <0.00%> (ø)
...r/transfer/process/TransferProcessManagerImpl.java 87.69% <86.20%> (-0.64%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndr-brt ndr-brt requested a review from wolf4ood March 27, 2023 15:06
@ndr-brt ndr-brt force-pushed the 2603-events-new-state-transitions branch from a6de13d to 753751d Compare March 28, 2023 06:47
@ndr-brt ndr-brt temporarily deployed to Azure-dev March 28, 2023 06:47 — with GitHub Actions Inactive
@ndr-brt ndr-brt force-pushed the 2603-events-new-state-transitions branch from 753751d to 32091c0 Compare March 30, 2023 07:08
@ndr-brt ndr-brt temporarily deployed to Azure-dev March 30, 2023 07:08 — with GitHub Actions Inactive
@ndr-brt ndr-brt merged commit 2a4946c into eclipse-edc:main Mar 30, 2023
@ndr-brt ndr-brt deleted the 2603-events-new-state-transitions branch March 30, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataspace protocol: dispatch events on new state transitions
3 participants