Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(negotiation): add correlationId to new RemoteMessages #2618

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented Mar 21, 2023

What this PR changes/adds

Adds correlationId to ContractAgreementVerificationMessage and ContractNegotiationEventMessage.

Why it does that

The dataspace protocol delegates need the negotiationId to build the URL for the request.

Further notes

Sry, missed that in #2595

Linked Issue(s)

Closes #2617

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • assigned appropriate label? (exclude from changelog with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@juliapampus juliapampus requested a review from ndr-brt March 21, 2023 18:52
@juliapampus juliapampus temporarily deployed to Azure-dev March 21, 2023 18:52 — with GitHub Actions Inactive
@juliapampus juliapampus changed the title feat: add correlationId to ContractAgreementVerificationMessage and ContractNegotiationEventMessage feat(contract-negotiation): add correlationId to new RemoteMessage Mar 21, 2023
@juliapampus juliapampus changed the title feat(contract-negotiation): add correlationId to new RemoteMessage feat(contract-negotiation): add correlationId to new RemoteMessages Mar 21, 2023
@juliapampus juliapampus added the enhancement New feature or request label Mar 21, 2023
@juliapampus juliapampus changed the title feat(contract-negotiation): add correlationId to new RemoteMessages feat(negotiation): add correlationId to new RemoteMessages Mar 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.03 ⚠️

Comparison is base (d407174) 64.56% compared to head (c1175c8) 64.54%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
- Coverage   64.56%   64.54%   -0.03%     
==========================================
  Files         890      890              
  Lines       18248    18258      +10     
  Branches     1087     1087              
==========================================
+ Hits        11782    11784       +2     
- Misses       6032     6040       +8     
  Partials      434      434              
Impacted Files Coverage Δ
...greement/ContractAgreementVerificationMessage.java 0.00% <0.00%> (ø)
...pes/agreement/ContractNegotiationEventMessage.java 0.00% <0.00%> (ø)
...iation/ConsumerContractNegotiationManagerImpl.java 92.46% <100.00%> (+0.05%) ⬆️
...iation/ProviderContractNegotiationManagerImpl.java 95.03% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juliapampus juliapampus temporarily deployed to Azure-dev March 22, 2023 07:55 — with GitHub Actions Inactive
@juliapampus juliapampus temporarily deployed to Azure-dev March 22, 2023 07:55 — with GitHub Actions Inactive
@juliapampus juliapampus merged commit faac84e into eclipse-edc:main Mar 22, 2023
@juliapampus juliapampus deleted the issue_2617 branch March 22, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteMessages for contract negotiation are missing processId
3 participants