-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce jwt-spi and jwt-core modules #1867
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1867 +/- ##
==========================================
- Coverage 62.54% 62.53% -0.01%
==========================================
Files 782 780 -2
Lines 16592 16587 -5
Branches 1079 1079
==========================================
- Hits 10377 10373 -4
+ Misses 5767 5766 -1
Partials 448 448
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@jimmarino , yesterday @bscholtes1A pointed out to the fact that the |
@ndr-brt In this case, it may be onerous to wrap and unwrap Nimbus classes. Are there a lot of classes that need to be wrapped? |
In the spi we are using three nimbus-jose classes:
the first two of them are actually used paired on the |
Sounds good to me. |
#1879 created. |
What this PR changes/adds
refactor
token-validation-lib
andtoken-generation-lib
to thespi
/core
patternWhy it does that
To accomplish project structure review
Further notes
jwt-spi
andjwt-core
as they are specific to JWT (using nimbus-jose jwt related classes)token-spi
module #1834 there is some duplication that could be avoided, but it was too much for this PR, will be something to be fixed in the futurecommon
folder could be moved incore/common
, as in the end they are core modules as well.Linked Issue(s)
Closes #1834
Checklist
no-changelog
)