-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restructure extensions
by component
#1863
feat: restructure extensions
by component
#1863
Conversation
I like this layout. A few comments and suggestions:
|
for what I understood, the
I was thinking the same, my first idea was "persistence", but "store" fits better and it is shorted, will address this.
could make sense to have EDIT: thinking about the last one... do they fit well in the
so the only thing to do could be to move |
+1 on those. I'm also fine to have data-plane-selector top-level. |
What this PR changes/adds
move all the
extensions
folders into theextensions
folder, grouped by the component they are needed by:Why it does that
To accomplish project structure review
Further notes
control-plane/provision/
orcommon/vault
).common
subfolder seem like the division by "provider" (e.g.aws/s3-core
orazure/blob-core
) is the only appliablecontrol-plane-cosmos
andcontrol-plane-sql
, they should be pretty self-explanatory and helpful for sure to build a control plain with a certain persistence systemazure-resource-manager
seems to be used only in pair withdata-plane-data-factory
so it could be considered adata-plane
extension, but wasn't sure so I let it into thecommon
folderblobstorage
module was inlined because it was giving nothing more than theblob-provider
extensions/common/iam
folder would need a further look.iam
could have its ownspi
and core module that register a mock/noop defaultIdentityService
then the related extensions could override it. to be addressed in another issue eventually.jetty-micrometer
andjersey-micrometer
should be moved to aextensions/common/micrometer
forlder instead of being included in theextensions/common/http
. For the moment I left them in the latter.Linked Issue(s)
Closes #1810
Checklist
no-changelog
)