Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: auto-upload SPROCs to CosmosDB #1339

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

This PR adds code sections that automatically upload all stored procedures that are needed by the extension. So far, this concerns only the CosmosTransferProcessStoreExtension and the CosmosContractNegotiationStoreExtension.

The auto-upload is enabled by default and can be disabled with those settings:

  • edc.contractnegotiationstore.cosmos.allow.sproc.autoupload=false
  • edc.transfer-process-store.cosmos.allow.sproc.autoupload=false

Why it does that

To avoid inconsistencies when the SPROCs are not there.

Further notes

Linked Issue(s)

Closes #1338

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger requested a review from ndr-brt May 20, 2022 12:45
@paullatzelsperger paullatzelsperger force-pushed the feature/1338_upload_sprocs branch from 91987af to 0e727d8 Compare May 20, 2022 12:45
@codecov-commenter
Copy link

Codecov Report

Merging #1339 (0e727d8) into main (db34d77) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
- Coverage   67.68%   67.63%   -0.05%     
==========================================
  Files         719      719              
  Lines       15859    15870      +11     
  Branches     1041     1043       +2     
==========================================
  Hits        10734    10734              
- Misses       4650     4661      +11     
  Partials      475      475              
Impacted Files Coverage Δ
...on/store/CosmosContractNegotiationStoreConfig.java 0.00% <0.00%> (ø)
...store/CosmosContractNegotiationStoreExtension.java 0.00% <0.00%> (ø)
...taspaceconnector/azure/cosmos/CosmosDbApiImpl.java 0.00% <0.00%> (ø)
...re/cosmos/CosmosTransferProcessStoreExtension.java 0.00% <0.00%> (ø)
...store/cosmos/TransferProcessStoreCosmosConfig.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db34d77...0e727d8. Read the comment docs.

@paullatzelsperger paullatzelsperger force-pushed the feature/1338_upload_sprocs branch from 0e727d8 to cae23db Compare May 20, 2022 13:24
@paullatzelsperger paullatzelsperger force-pushed the feature/1338_upload_sprocs branch from cae23db to 261651a Compare May 20, 2022 13:28
@paullatzelsperger paullatzelsperger merged commit 1608edd into eclipse-edc:main May 20, 2022
ndr-brt pushed a commit that referenced this pull request May 20, 2022
juliapampus pushed a commit to FraunhoferISST/edc-connector that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos: SPROCs should be deployed during extension initialization
3 participants