Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove TransferProcess connectorId #3396

Closed
ndr-brt opened this issue Aug 31, 2023 · 11 comments · Fixed by #3625
Closed

refactor: remove TransferProcess connectorId #3396

ndr-brt opened this issue Aug 31, 2023 · 11 comments · Fixed by #3625
Assignees
@hamidonos
Labels
api Feature related to the (REST) api good first issue Good for newcomers refactoring Cleaning up code and dependencies

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Aug 31, 2023

Feature Request

Currently, both TransferRequest and DataRequest objects contain this connectorId that's actually not used by anyone, it's not needed, because the counter-party id it's stored in the ContractAgreement, so connectorId can be removed

Which Areas Would Be Affected?

transfer process

Why Is the Feature Desired?

cleanup

Solution Proposal

If possible, provide a (brief!) solution proposal.
@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies api Feature related to the (REST) api good first issue Good for newcomers labels Aug 31, 2023
@salmansharifov
Copy link

Hi @ndr-brt Can I take over this issue? T

@ndr-brt
Copy link
Member Author

ndr-brt commented Sep 1, 2023

sure! I just assigned it to you. thanks

@magork
Copy link

magork commented Sep 1, 2023

Hi I have removed from the classes the connectorId

@ndr-brt
Copy link
Member Author

ndr-brt commented Sep 4, 2023

@magork the issued was assigned to @salmansharifov , why don't sync with him first?

@magork
Copy link

magork commented Sep 4, 2023

Hi This is my first time when I contribute. I am expecting that what I have done is not enough and still should do further changes. Hi @salmansharifov could we connect?

@ndr-brt
Copy link
Member Author

ndr-brt commented Sep 4, 2023 •
edited
Loading

As I wrote in the PR, I suggest to read through the CONTRIBUTING guide, as a rule of thumb this is something that should be done before starting contributing to every project.

@salmansharifov
Copy link

Hi @magork , if you have already working branch, you can create pr.

@magork
Copy link

magork commented Sep 11, 2023

Hi @salmansharifov Sorry to answer late but I where on a trip and I didn't have my laptop.
So I forked the project and made some changes in those classes but jobs are failing. Could we connect and discuss in more detail the required changes which are needed?

@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Oct 10, 2023
@ndr-brt
Copy link
Member Author

ndr-brt commented Oct 10, 2023

Hey @salmansharifov are you gonna work on it? otherwise I will remove the assignment

@github-actions github-actions bot removed the stale Open for x days with no activity label Oct 11, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Nov 8, 2023
@ndr-brt ndr-brt removed the stale Open for x days with no activity label Nov 8, 2023
@hamidonos hamidonos self-assigned this Nov 16, 2023
hamidonos added a commit to mercedes-benz/EclipseDataSpaceConnector that referenced this issue Nov 17, 2023
@hamidonos
refactor: remove connector id (eclipse-edc#3396)
63497d6
@hamidonos hamidonos mentioned this issue Nov 17, 2023
Merged
ndr-brt pushed a commit that referenced this issue Dec 6, 2023
@hamidonos
refactor: remove TransferProcess connectorId (#3625)
924a977 
* feat: add PrefixMonitor (#3510)

* refactor: remove connector id (#3396)

* fix: add missing "since"

* fix: add missing table name in drop column statement

* fix: remove connector id from tests

* refactor: add deprecated warning to swagger api

* fix: remove wrong change

* fix: remove connector_id from schema creation in schema.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamidonos hamidonos

Labels
api Feature related to the (REST) api good first issue Good for newcomers refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove TransferProcess connectorId mercedes-benz/EclipseDataSpaceConnector
4 participants
@ndr-brt @magork @salmansharifov @hamidonos