Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty-file issue #66

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Fixed empty-file issue #66

merged 4 commits into from
Mar 1, 2024

Conversation

FlorianReimold
Copy link
Member

@FlorianReimold FlorianReimold commented Mar 1, 2024

Fixed a bug that caused empty files to be not downloadable.
Added GTest that tests uploading and downloading empty files.

Before, files with no content reported an error when trying to download them. Now, they are properly "downloaded", i.e. the data socket is opened and immediately a finished data transfer is reported.

Fixes #64

@FlorianReimold FlorianReimold marked this pull request as ready for review March 1, 2024 09:36
@FlorianReimold FlorianReimold merged commit 3668eda into master Mar 1, 2024
19 checks passed
@FlorianReimold FlorianReimold deleted the hotfix/empty_files branch March 1, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems downloading an empty file
1 participant