fix[cmake]: Remove thirdparty build options from presets #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the submodule dependency provider dependencies are only pulled into the build when needed and are excluded from all anyway
KerstinKeller
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes all the explicit CMake options to disable building from the submodules. With the submodule dependency provider dependencies are only pulled into the build when needed and are excluded from all anyway. They were only disabling unused dependencies.
This fixes usage of the presets on Windows where curl and hdf5 weren't being set (was relying on logic that got deleted in the transition)
Related issues
Cherry-pick to