Feature/subscriber callback #1982

KerstinKeller · 2025-01-31T07:40:30Z

Description

split v5 and v6 SCallbackData.
Rename v6 SCallbackData fields,

…ersion in the next step.

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-31T07:53:29Z

app/rec/rec_client_core/src/frame.h

-        data_.reserve(callback_data->size);
-        data_.assign((char*)callback_data->buf, (char*)callback_data->buf + callback_data->size);
+        data_.reserve(callback_data->buffer_size);
+        data_.assign((char*)callback_data->buffer, (char*)callback_data->buffer + callback_data->buffer_size);


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

data_.assign((char*)callback_data->buffer, (char*)callback_data->buffer + callback_data->buffer_size); ^

github-actions · 2025-01-31T07:53:29Z

app/rec/rec_client_core/src/frame.h

-        data_.reserve(callback_data->size);
-        data_.assign((char*)callback_data->buf, (char*)callback_data->buf + callback_data->size);
+        data_.reserve(callback_data->buffer_size);
+        data_.assign((char*)callback_data->buffer, (char*)callback_data->buffer + callback_data->buffer_size);


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

data_.assign((char*)callback_data->buffer, (char*)callback_data->buffer + callback_data->buffer_size); ^

github-actions · 2025-01-31T07:53:29Z

ecal/core/include/ecal/pubsub/types.h

-  enum class eSubscriberEvent
+  * @brief eCAL publisher event callback type.
+  **/
+  enum class ePublisherEvent


warning: enum 'ePublisherEvent' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

^

github-actions · 2025-01-31T07:53:29Z

ecal/core/include/ecal/pubsub/types.h

-  enum class ePublisherEvent
+ * @brief eCAL subscriber event callback type.
+**/
+  enum class eSubscriberEvent


warning: enum 'eSubscriberEvent' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

^

github-actions · 2025-01-31T07:53:29Z

ecal/samples/cpp/pubsub/binary/binary_rec/src/binary_rec.cpp


-  int content(static_cast<int>(static_cast<unsigned char*>(data_.buf)[0]));
+  int content(static_cast<int>(static_cast<const unsigned char*>(data_.buffer)[0]));


warning: variable 'content' of type 'int' can be declared 'const' [misc-const-correctness]

Suggested change

int content(static_cast<int>(static_cast<const unsigned char*>(data_.buffer)[0]));

int const content(static_cast<int>(static_cast<const unsigned char*>(data_.buffer)[0]));

github-actions · 2025-01-31T07:53:29Z

ecal/tests/cpp/pubsub_test/src/pubsub_acknowledge.cpp

@@ -63,7 +63,7 @@ TEST(core_cpp_pubsub, TimeoutAcknowledgment)
  auto sub1 = std::make_shared< eCAL::CSubscriber>("topic");
  auto sleeper_variable_time = [](const eCAL::STopicId& /*topic_id_*/, const eCAL::SDataTypeInformation&  /*data_type_info_*/, const eCAL::SReceiveCallbackData& data_)
                                {
-                                  std::string const sleep_time((const char*)data_.buf, data_.size);
+                                  std::string const sleep_time((const char*)data_.buffer, data_.buffer_size);


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

std::string const sleep_time((const char*)data_.buffer, data_.buffer_size); ^

github-actions · 2025-01-31T07:53:29Z

ecal/tests/cpp/pubsub_test/src/pubsub_test_shm.cpp

@@ -130,8 +130,8 @@ TEST(core_cpp_pubsub, MultipleSendsSHM)
  // add callback
  auto save_data = [&last_received_msg, &last_received_timestamp](const eCAL::STopicId& /*topic_id_*/, const eCAL::SDataTypeInformation& /*data_type_info_*/, const eCAL::SReceiveCallbackData& data_)
  {
-    last_received_msg = std::string{ (const char*)data_.buf, (size_t)data_.size};
-    last_received_timestamp = data_.time;
+    last_received_msg = std::string{ (const char*)data_.buffer, (size_t)data_.buffer_size};


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

last_received_msg = std::string{ (const char*)data_.buffer, (size_t)data_.buffer_size}; ^

github-actions · 2025-01-31T07:53:30Z

ecal/tests/cpp/pubsub_test/src/pubsub_test_udp.cpp

@@ -116,8 +116,8 @@ TEST(core_cpp_pubsub, MultipleSendsUDP)
  // add callback
  auto save_data = [&last_received_msg, &last_received_timestamp](const eCAL::STopicId& /*topic_id_*/, const eCAL::SDataTypeInformation& /*data_type_info_*/, const eCAL::SReceiveCallbackData& data_)
  {
-    last_received_msg = std::string{ (const char*)data_.buf, (size_t)data_.size };
-    last_received_timestamp = data_.time;
+    last_received_msg = std::string{ (const char*)data_.buffer, (size_t)data_.buffer_size };


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

last_received_msg = std::string{ (const char*)data_.buffer, (size_t)data_.buffer_size }; ^

github-actions · 2025-01-31T07:53:30Z

lang/python/core/src/ecal_clang.cpp

@@ -528,7 +528,7 @@ bool sub_receive_buffer(ECAL_HANDLE handle_, const char** rcv_buf_, int* rcv_buf
 /*      sub_add_receive_callback        */
 /****************************************/
 static std::mutex g_sub_receive_callback_mtx;
-static void g_sub_receive_callback(const char* topic_name_, const struct eCAL::SReceiveCallbackData* data_, const ReceiveCallbackCT callback_, void* par_)
+static void g_sub_receive_callback(const char* topic_name_, const struct eCAL::v5::SReceiveCallbackData* data_, const ReceiveCallbackCT callback_, void* par_)


warning: function 'g_sub_receive_callback' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace]

static void g_sub_receive_callback(const char* topic_name_, const struct eCAL::v5::SReceiveCallbackData* data_, const ReceiveCallbackCT callback_, void* par_) ^

github-actions · 2025-01-31T07:53:30Z

lang/python/core/src/ecal_wrap.cxx

@@ -368,7 +368,7 @@ PyObject* sub_receive(PyObject* /*self*/, PyObject* args)
 /****************************************/
 /*      sub_set_callback                */
 /****************************************/
-static void c_subscriber_callback(const char* topic_name_, const struct eCAL::SReceiveCallbackData* data_, ECAL_HANDLE handle_, const std::string& /*python_formatter*/)
+static void c_subscriber_callback(const char* topic_name_, const struct eCAL::v5::SReceiveCallbackData* data_, ECAL_HANDLE handle_, const std::string& /*python_formatter*/)


warning: function 'c_subscriber_callback' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace]

static void c_subscriber_callback(const char* topic_name_, const struct eCAL::v5::SReceiveCallbackData* data_, ECAL_HANDLE handle_, const std::string& /*python_formatter*/) ^

KerstinKeller added 3 commits January 30, 2025 22:45

[core] Introduce v5 SCallbackData type, to be able to change the v6 v…

f3e3522

…ersion in the next step.

[core] Rework SReceiveCallbackData.

6b476f7

Rename back to clock, because that term is used in many other places.

cf38d1f

KerstinKeller requested review from rex-schilasky and hannemn January 31, 2025 07:40

KerstinKeller added the cherry-pick-to-NONE Don't cherry-pick these changes label Jan 31, 2025

KerstinKeller requested a review from Peguen January 31, 2025 07:43

github-actions bot reviewed Jan 31, 2025

View reviewed changes

hannemn approved these changes Jan 31, 2025

View reviewed changes

Peguen approved these changes Jan 31, 2025

View reviewed changes

Remove cast and change type of clock.

cee3f05

hannemn approved these changes Jan 31, 2025

View reviewed changes

KerstinKeller requested a review from hannemn January 31, 2025 09:32

KerstinKeller merged commit d9faad3 into master Jan 31, 2025
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/subscriber callback #1982

Feature/subscriber callback #1982

KerstinKeller commented Jan 31, 2025

github-actions bot left a comment

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025

github-actions bot Jan 31, 2025


		int content(static_cast<int>(static_cast<unsigned char*>(data_.buf)[0]));
		int content(static_cast<int>(static_cast<const unsigned char*>(data_.buffer)[0]));

	int content(static_cast<int>(static_cast<const unsigned char*>(data_.buffer)[0]));
	int const content(static_cast<int>(static_cast<const unsigned char*>(data_.buffer)[0]));

Feature/subscriber callback #1982

Feature/subscriber callback #1982

Conversation

KerstinKeller commented Jan 31, 2025

Description

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot Jan 31, 2025

Choose a reason for hiding this comment