new publisher parameter api (sync with eclipse-ecal) #66

rex-schilasky · 2024-04-27T06:03:52Z

No description provided.

github-actions

clang-tidy made some suggestions

ecal/core/include/ecal/msg/capnproto/publisher.h

ecal/core/include/ecal/msg/protobuf/dynamic_publisher.h

ecal/core/include/ecal/msg/publisher.h

ecal/core/include/ecal/msg/string/publisher.h

ecal/tests/cpp/pubsub_test/src/pubsub_test.cpp

github-actions

clang-tidy made some suggestions

ecal/core/src/readwrite/shm/ecal_writer_shm.cpp

github-actions

clang-tidy made some suggestions

ecal/tests/cpp/pubsub_test/src/pubsub_test.cpp

ecal/tests/cpp/pubsub_test/src/pubsub_test_shm.cpp

ecal/tests/cpp/pubsub_test/src/pubsub_test_udp.cpp

github-actions

clang-tidy made some suggestions

ecal/core/include/ecal/ecal_publisher_config.h

ecal/core/include/ecal/msg/flatbuffers/publisher.h

ecal/core/include/ecal/msg/publisher.h

ecal/core/include/ecal/msg/string/publisher.h

github-actions

clang-tidy made some suggestions

ecal/core/include/ecal/msg/capnproto/publisher.h

ecal/tests/cpp/pubsub_test/src/pubsub_test.cpp

SHMConfig -> Publisher::SHM::Configuration UDPConfig -> Publisher::UDP::Configuration TCPConfig -> Publisher::TCP::Configuration

github-actions

clang-tidy made some suggestions

ecal/core/include/ecal/msg/capnproto/publisher.h

ecal/core/include/ecal/msg/publisher.h

github-actions · 2024-05-06T11:53:26Z

ecal/core/include/ecal/msg/string/publisher.h

@@ -60,7 +60,7 @@ namespace eCAL

      // call the function via its class because it's a virtual function that is called in constructor/destructor,-
      // where the vtable is not created yet, or it's destructed.
-      explicit CPublisher(const std::string& topic_name_) : CMsgPublisher<T>(topic_name_, GetDataTypeInformation())
+      explicit CPublisher(const std::string& topic_name_, const eCAL::Publisher::Configuration& config_ = {}) : CMsgPublisher<T>(topic_name_, GetDataTypeInformation(), config_)


warning: Call to virtual method 'CPublisher::GetDataTypeInformation' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]

explicit CPublisher(const std::string& topic_name_, const eCAL::Publisher::Configuration& config_ = {}) : CMsgPublisher<T>(topic_name_, GetDataTypeInformation(), config_) ^

Additional context

ecal/tests/cpp/pubsub_test/src/pubsub_acknowledge.cpp:50: Control jumps to 'case 0:' at line 51

EXPECT_EQ(0, eCAL::Initialize(0, nullptr, "TimeoutAcknowledgment", eCAL::Init::All)); ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest.h:1868: expanded from macro 'EXPECT_EQ'

EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:143: expanded from macro 'EXPECT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:77: expanded from macro 'GTEST_ASSERT_'

GTEST_AMBIGUOUS_ELSE_BLOCKER_ \ ^

thirdparty/gtest/googletest/googletest/include/gtest/internal/gtest-port.h:711: expanded from macro 'GTEST_AMBIGUOUS_ELSE_BLOCKER_'

switch (0) \ ^

ecal/tests/cpp/pubsub_test/src/pubsub_acknowledge.cpp:50: Assuming the condition is true

EXPECT_EQ(0, eCAL::Initialize(0, nullptr, "TimeoutAcknowledgment", eCAL::Init::All)); ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest.h:1868: expanded from macro 'EXPECT_EQ'

EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:143: expanded from macro 'EXPECT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:78: expanded from macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^

ecal/tests/cpp/pubsub_test/src/pubsub_acknowledge.cpp:50: Taking true branch

EXPECT_EQ(0, eCAL::Initialize(0, nullptr, "TimeoutAcknowledgment", eCAL::Init::All)); ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest.h:1868: expanded from macro 'EXPECT_EQ'

EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:143: expanded from macro 'EXPECT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

thirdparty/gtest/googletest/googletest/include/gtest/gtest_pred_impl.h:78: expanded from macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^

ecal/tests/cpp/pubsub_test/src/pubsub_acknowledge.cpp:60: Calling constructor for 'CPublisher<std::basic_string>'

eCAL::string::CPublisher<std::string> pub("topic", pub_config); ^

ecal/core/include/ecal/msg/string/publisher.h:62: Call to virtual method 'CPublisher::GetDataTypeInformation' during construction bypasses virtual dispatch

explicit CPublisher(const std::string& topic_name_, const eCAL::Publisher::Configuration& config_ = {}) : CMsgPublisher<T>(topic_name_, GetDataTypeInformation(), config_) ^

github-actions

clang-tidy made some suggestions

ecal/core/src/readwrite/ecal_writer.cpp

…d ext/loc)

github-actions

clang-tidy made some suggestions

ecal/core/src/readwrite/ecal_reader.cpp

ecal/core/src/readwrite/ecal_writer.cpp

ecal/core/src/readwrite/shm/ecal_writer_shm.h

github-actions

clang-tidy made some suggestions

ecal/core/src/readwrite/ecal_writer.cpp

ecal/core/src/readwrite/ecal_writer.h

reader Create/Destroy replaced by Constructor/Destructor

github-actions

clang-tidy made some suggestions

ecal/core/src/readwrite/ecal_reader.cpp

ecal/core/src/readwrite/ecal_writer.cpp

…scriber, client, server) Create/Destroy -> Start/Stop

github-actions

clang-tidy made some suggestions

github-actions · 2024-05-10T17:00:32Z

ecal/core/src/pubsub/ecal_subgate.cpp

  }

-  void CSubGate::Create()
+  void CSubGate::Start()


warning: method 'Start' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/pubsub/ecal_subgate.h:42:

- void Start(); + static void Start();

github-actions · 2024-05-10T17:00:32Z

ecal/core/src/service/ecal_clientgate.cpp

  }

-  void CClientGate::Create()
+  void CClientGate::Start()


warning: method 'Start' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/service/ecal_clientgate.h:47:

- void Start(); + static void Start();

ecal/core/src/service/ecal_service_client_impl.h

github-actions · 2024-05-10T17:00:32Z

ecal/core/src/service/ecal_servicegate.cpp

  }

-  void CServiceGate::Create()
+  void CServiceGate::Start()


warning: method 'Start' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/service/ecal_servicegate.h:41:

- void Start(); + static void Start();

…ctions)

…ged dynamically anymore) frequency calculator reset factor set back to 3.0f

alignment

rex-schilasky added 2 commits April 27, 2024 08:03

new publisher parameter api (sync with eclipse-ecal)

b09c5c8

added missing files

8fe3170

github-actions bot reviewed Apr 27, 2024

View reviewed changes

CPublisher::Config used in all writers

69fb2b7

github-actions bot reviewed Apr 29, 2024

View reviewed changes

ecal/core/src/readwrite/shm/ecal_writer_shm.cpp Outdated Show resolved Hide resolved

ecal/core/src/readwrite/shm/ecal_writer_shm.cpp Outdated Show resolved Hide resolved

ecal/core/src/readwrite/shm/ecal_writer_shm.cpp Outdated Show resolved Hide resolved

rex-schilasky added 6 commits April 29, 2024 18:58

xxx_udp_mc.yy -> xxx_udp.yy

4bdb97d

clang-tidy

b88bd98

pubsub tests reclustered (shm, udp, tcp)

3a18478

more pubsub tests sorted out for shm only

3f66cd7

added two missing tests

0ba2e52

more pubsub tests sorted out for shm only

a009e38

github-actions bot reviewed Apr 30, 2024

View reviewed changes

publisher config separated

e0ffe4c

github-actions bot reviewed May 2, 2024

View reviewed changes

clang-tidy + PubConfig fixed

7984e2c

github-actions bot reviewed May 2, 2024

View reviewed changes

rex-schilasky added 3 commits May 3, 2024 10:08

constness

667445e

cosmetic ..

d29d850

PubConfig -> Publisher::Configuration

526af68

SHMConfig -> Publisher::SHM::Configuration UDPConfig -> Publisher::UDP::Configuration TCPConfig -> Publisher::TCP::Configuration

github-actions bot reviewed May 6, 2024

View reviewed changes

rex-schilasky added 2 commits May 6, 2024 14:57

improved documentation

a5bd933

transport layer activation logic simplified (not finished yet)

9110c21

github-actions bot reviewed May 7, 2024

View reviewed changes

ecal/core/src/readwrite/ecal_writer.cpp Outdated Show resolved Hide resolved

internal reader/writer map handling redesigned (one common map instea…

a07b759

…d ext/loc)

github-actions bot reviewed May 8, 2024

View reviewed changes

ecal/core/src/readwrite/ecal_reader.cpp Show resolved Hide resolved

ecal/core/src/readwrite/ecal_writer.cpp Outdated Show resolved Hide resolved

ecal/core/src/readwrite/shm/ecal_writer_shm.h Outdated Show resolved Hide resolved

rex-schilasky added 2 commits May 8, 2024 08:27

clang-tidy

8434785

renamings, layer info added to internal pub/sub maps

57d4ae9

github-actions bot reviewed May 8, 2024

View reviewed changes

ecal/core/src/readwrite/ecal_writer.cpp Outdated Show resolved Hide resolved

ecal/core/src/readwrite/ecal_writer.h Show resolved Hide resolved

atomic Initialization

2acf786

reader Create/Destroy replaced by Constructor/Destructor

github-actions bot reviewed May 8, 2024

View reviewed changes

ecal/core/src/readwrite/ecal_reader.cpp Outdated Show resolved Hide resolved

ecal/core/src/readwrite/ecal_reader.cpp Outdated Show resolved Hide resolved

ecal/core/src/readwrite/ecal_writer.cpp Outdated Show resolved Hide resolved

Stop function introduced (former Destroy) to shutdown (publisher, sub…

bc1573c

…scriber, client, server) Create/Destroy -> Start/Stop

github-actions bot reviewed May 10, 2024

View reviewed changes

rex-schilasky added 9 commits May 11, 2024 10:26

core_cpp_pubsub, TimeoutAcknowledgment timing changed (failed on GH a…

5569e7b

…ctions)

changed naming activate to enable for shm, udp, tcp layer configuration

6888064

clang-tidy

a68e638

memfile buffer number removed from writer attributes (can not be chan…

c7f4ac7

…ged dynamically anymore) frequency calculator reset factor set back to 3.0f

single component finalizing removed

b7ca2a8

alignment

eCAL::Finalize() fixed (no more parameter)

f7fa4aa

cleanup

7b2155d

fixed zero copy mode on/off logic

32dcd98

syntax error

4637fc4

rex-schilasky merged commit 95b27b8 into main May 16, 2024
82 checks passed

rex-schilasky deleted the feature/parameter-api-publisher branch May 16, 2024 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new publisher parameter api (sync with eclipse-ecal) #66

new publisher parameter api (sync with eclipse-ecal) #66

rex-schilasky commented Apr 27, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot May 6, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot May 10, 2024

github-actions bot May 10, 2024

github-actions bot May 10, 2024

new publisher parameter api (sync with eclipse-ecal) #66

new publisher parameter api (sync with eclipse-ecal) #66

Conversation

rex-schilasky commented Apr 27, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot May 6, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot May 10, 2024

Choose a reason for hiding this comment

github-actions bot May 10, 2024

Choose a reason for hiding this comment

github-actions bot May 10, 2024

Choose a reason for hiding this comment